emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/magit 5b4c4aea1b 2/3: Fix regression in transient-init-val


From: Jonas Bernoulli
Subject: [nongnu] elpa/magit 5b4c4aea1b 2/3: Fix regression in transient-init-value methods
Date: Sun, 8 Dec 2024 17:36:08 -0500 (EST)

branch: elpa/magit
commit 5b4c4aea1bd90b296373777f0588acbe2ea6eec5
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Fix regression in transient-init-value methods
    
    Fix typo in cosmetic change done in [1: 06f3ffa868].
    
    I wish these macros were implemented more intelligently, so that the
    byte-compiler could catch such mistakes.  This should have result in
    unused variable warnings.
    
    1: 2024-10-17 06f3ffa868f9aaa4ddeaf65811f315fdb6a4a626
       Merge when-let and neighboring conditionals
---
 lisp/magit-diff.el | 2 +-
 lisp/magit-log.el  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/magit-diff.el b/lisp/magit-diff.el
index e8214eef84..635ed2c5a5 100644
--- a/lisp/magit-diff.el
+++ b/lisp/magit-diff.el
@@ -796,7 +796,7 @@ and `:slant'."
   (pcase-let ((`(,args ,files)
                (magit-diff--get-value 'magit-diff-mode
                                       magit-prefix-use-buffer-arguments)))
-    (when-let ((not (eq transient-current-command 'magit-dispatch))
+    (when-let (((not (eq transient-current-command 'magit-dispatch)))
                (file (magit-file-relative-name)))
       (setq files (list file)))
     (oset obj value (if files `(("--" ,@files) ,args) args))))
diff --git a/lisp/magit-log.el b/lisp/magit-log.el
index 3b39a6ebdc..e452e2dab5 100644
--- a/lisp/magit-log.el
+++ b/lisp/magit-log.el
@@ -353,7 +353,7 @@ commits before and half after."
   (pcase-let ((`(,args ,files)
                (magit-log--get-value 'magit-log-mode
                                      magit-prefix-use-buffer-arguments)))
-    (when-let ((not (eq transient-current-command 'magit-dispatch))
+    (when-let (((not (eq transient-current-command 'magit-dispatch)))
                (file (magit-file-relative-name)))
       (setq files (list file)))
     (oset obj value (if files `(("--" ,@files) ,args) args))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]