[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/subed f72f4d42ee 2/3: Clear file duration cache when loadi
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/subed f72f4d42ee 2/3: Clear file duration cache when loading a file |
Date: |
Tue, 17 Dec 2024 16:02:55 -0500 (EST) |
branch: elpa/subed
commit f72f4d42eee4901721fb1ce11ef8d78b1eff0d67
Author: Sacha Chua <sacha@sachachua.com>
Commit: Sacha Chua <sacha@sachachua.com>
Clear file duration cache when loading a file
* subed/subed-waveform.el: Remove advice.
* subed/subed-mpv.el (subed-mpv-play-from-file-hook):
New hook.
* subed/subed-mpv.el (subed-mpv-play-from-file):
Clear file duration.
---
subed/subed-mpv.el | 8 +++++++-
subed/subed-waveform.el | 4 ----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/subed/subed-mpv.el b/subed/subed-mpv.el
index 6d18f26acf..9aa38933ec 100644
--- a/subed/subed-mpv.el
+++ b/subed/subed-mpv.el
@@ -402,6 +402,9 @@ hosting providers."
(setq subed-mpv-media-file url)
(subed-mpv--play url))
+(defvar subed-mpv-play-from-file-hook nil "Functions to run after a media file
is loaded.
+Called with FILE as argument.")
+
(defun subed-mpv-play-from-file (file)
"Open FILE in mpv.
@@ -409,7 +412,10 @@ Files are expected to have any of the extensions listed in
`subed-video-extensions' or `subed-audio-extensions'."
(interactive (list (read-file-name "Find media: " nil nil t nil
#'subed-mpv--is-media-file-p)))
(setq subed-mpv-media-file (expand-file-name file))
- (subed-mpv--play (expand-file-name file)))
+ (subed-clear-file-duration-ms-cache)
+ (subed-mpv--play (expand-file-name file))
+ (run-hook-with-args subed-mpv-play-from-file-hook))
+
(define-obsolete-function-alias 'subed-mpv-find-video
'subed-mpv-play-from-file "1.20")
(defun subed-mpv--add-subtitle-after-first-save ()
diff --git a/subed/subed-waveform.el b/subed/subed-waveform.el
index 0df6e29b88..4e3fca6aa6 100644
--- a/subed/subed-waveform.el
+++ b/subed/subed-waveform.el
@@ -250,10 +250,6 @@ WIDTH and HEIGHT are given in pixels."
(make-obsolete 'subed-waveform-file-duration-ms 'subed-file-duration-ms
"1.2.22")
(make-obsolete 'subed-waveform-clear-file-duration-ms-cache
'subed-clear-file-duration-ms-cache "1.2.22")
-;; This should eventually be replaced with a hook.
-(with-eval-after-load 'subed-mpv
- (advice-add 'subed-mpv-play-from-file :after
'subed-waveform-clear-file-duration-ms-cache))
-
(defun subed-waveform--from-file (filename from to width height)
"Returns a string representing the image data in PNG format.
FILENAME is the input file, FROM and TO are time positions, WIDTH