emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org-remark 868cce1081 1/4: fix: org-remark-info-mode in


From: ELPA Syncer
Subject: [elpa] externals/org-remark 868cce1081 1/4: fix: org-remark-info-mode interfering with isearch-forward #93 (#94)
Date: Thu, 23 Jan 2025 15:58:55 -0500 (EST)

branch: externals/org-remark
commit 868cce10812c2b21cbc4df9d586d18a8991ee025
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>

    fix: org-remark-info-mode interfering with isearch-forward #93 (#94)
    
    Info-selection-hook gets triggered for both the cases that the original
    Info-find-node and Info-search advice functions were meant to cover.
---
 org-remark-info.el | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/org-remark-info.el b/org-remark-info.el
index 334ae1195d..f7ce23372f 100644
--- a/org-remark-info.el
+++ b/org-remark-info.el
@@ -5,7 +5,7 @@
 ;; Author: Noboru Ota <me@nobiot.com>
 ;; URL: https://github.com/nobiot/org-remark
 ;; Created: 16 July 2023
-;; Last modified: 21 January 2024
+;; Last modified: 23 January 2025
 ;; Package-Requires: ((emacs "27.1") (org "9.4"))
 ;; Keywords: org-mode, annotation, note-taking, marginal-notes, wp
 
@@ -74,15 +74,13 @@
                     #'org-remark-info-get-node)
           (add-hook 'org-remark-highlight-link-to-source-functions
                     #'org-remark-info-link)
-          (advice-add #'Info-find-node :after 
#'org-remark-info-highlights-load)
-          (advice-add #'Info-search :after #'org-remark-info-highlights-load))
+          (add-hook 'Info-selection-hook #'org-remark-info-highlights-load))
     ;; Disable
     (remove-hook 'org-remark-source-find-file-name-functions
                  #'org-remark-info-get-node)
     (remove-hook 'org-remark-highlight-link-to-source-functions
                  #'org-remark-info-link)
-    (advice-remove #'Info-find-node #'org-remark-info-highlights-load)
-    (advice-remove #'Info-search #'org-remark-info-highlights-load)))
+    (remove-hook 'Info-selection-hook #'org-remark-info-highlights-load)))
 
 (defun org-remark-info-highlights-load (&rest _args)
   "Wrapper for `org-remark-highlights-load'.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]