[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Orgmode] [PATCH] fix infinite loop in csv table import
From: |
David Maus |
Subject: |
Re: [Orgmode] [PATCH] fix infinite loop in csv table import |
Date: |
Tue, 20 Jul 2010 07:30:01 +0200 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
Eric Schulte wrote:
>Hi,
>I've just noticed that I get an infinite loop when importing csv tables
>into Org-mode tables. For example calling
> (org-table-convert-region (point-min) (point-max) '(4))
>from inside of a simple text file containing the following
>--8<---------------cut here---------------start------------->8---
>1,2,3
>1
>2
>3
>5
>--8<---------------cut here---------------end--------------->8---
>results in an infinite loop. The attached patch fixes this issue [1],
>however it seems weird that this would just surface now, given that the
>code in question has been in the repo since last fall
This patch looks good to me: If the end of the region happens to be
end-of-buffer point will never be greater than end and the loop loops
forever.
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... address@hidden
Email..... address@hidden
pgp701T2EQ7Mn.pgp
Description: PGP signature