[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Orgmode] [PATCH] Removed unecessary invocations of org-agenda-show.
From: |
Matthew Lundin |
Subject: |
Re: [Orgmode] [PATCH] Removed unecessary invocations of org-agenda-show. |
Date: |
Thu, 16 Sep 2010 00:22:13 -0400 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) |
Hi Carsten,
Carsten Dominik <address@hidden> writes:
> On Sep 13, 2010, at 6:48 PM, Matt Lundin wrote:
>
>>
>> lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to
>> prevent
>> disrupting windows and changing point in original buffer.
>> (org-agenda-set-property): Same
>> (org-agenda-set-effort): Same
>> (org-agenda-toggle-archive-tag): Same
>>
>> When setting a tag in the agenda, org-mode displays the corresponding
>> entry in the original org buffer by calling org-agenda-show. This has
>> the unwelcome side-effect of disrupting the current window arrangement
>> and changing the position of the point in the original buffer. This
>> behavior is inconsistent with the that of org-agenda-todo, which makes
>> all its changes "silently."
>
> I agree, but I am sure I used to have problems with something
> which is why this was added.
> Have you been running this patch for some time already?
> Without any problems like the agenda jumping to a wrong place in a org
> file or so?
I haven't yet encountered any deleterious side effects, but I agree that
this patch needs further consideration. I will do some additional
research/testing and return with a report. :)
Best,
Matt