Re: [O] [PATCH] Re: TODO state change from TODO to DONE blocked

[Bastien]

Hi Sébastien,

Sébastien Vauban <address@hidden> writes:

>> - if the output message could be updated to make it clear what the reason is,
>>   or can be?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 3a07cfd..fb60bc6 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10927,7 +10927,10 @@ For calling through lisp, arg is also interpreted in 
> the following way:
>                       (run-hook-with-args-until-failure
>                        'org-blocker-hook change-plist)))
>             (if (interactive-p)
> -               (error "TODO state change from %s to %s blocked" this state)
> +               (error (concat "TODO state change from %s to %s blocked "
> +                              "(because of undone child, or "
> +                              "parent with ORDERED property and undone prior 
> sibling)")
> +                      this state)

I'm not in favor of displaying such a long error message: I find it not
easily readable, and it raises too many potential causes for the error.

The user already knows about these various reasons by reading the
docstring of `org-enforce-todo-dependencies', which defaults to `nil'.

Thanks anyway for the patch!

-- 
 Bastien