Re: [O] Version 7.5: C-c C-t <anything> fails with "args out of range"

[Josh Berry]

On Tue, Mar 8, 2011 at 22:55, Carsten Dominik <address@hidden> wrote:
>
> On 9.3.2011, at 06:49, David Maus wrote:
>
>> At Tue, 8 Mar 2011 15:08:57 -0800,
>> Josh Berry wrote:
>>>
>>> Hi list,
>>>
>>> I just upgraded from org-mode 7.4 to 7.5, and I can't set or change
>>> TODO states at all with C-c C-t now; an args-out-of-range error gets
>>> raised.  I've tried doing a "make clean" in my org-mode checkout, to
>>> no avail.
>>>
>>> I'm running GNU emacs 23.2.1 on Mac OSX (in Aqua), installed via
>>> Homebrew.  Debugger backtrace is pasted below.
>>>
>>> [[BTW, please forgive me if this isn't a well-formed bug report; I'm
>>> relatively new to Emacs and don't know Elisp.  Just let me know if you
>>> need anything else.]]
>>
>> Just a fast comment: Couldn't this be a problem with the macro
>> `org-with-wide-buffer'?
>>
>> #+begin_src emacs-lisp
>> (defmacro org-with-wide-buffer (&rest body)
>>  "Execute body while temporarily widening the buffer."
>>  `(let ((beg (point-min)) (end (point-max)) (pos (point)))
>>     (prog2
>>        (widen)
>>        ,@body
>>       (narrow-to-region beg end)
>>       (goto-char pos))))
>> #+end_src
>
> This macro is indeed not written in a stable way and will
> fail of the buffer gets modified with @body.
> But Emacs already has save-restriction, so there is no
> need to re-invent the wheel:
>
> (defmacro org-with-wide-buffer (&rest body)
>  "Execute body while temporarily widening the buffer."
>  `(save-excursion
>    (save-restriction
>       (widen)
>       ,@body)))

I just hacked your version of org-with-wide-buffer into my org-macs.el
file, and it appears to fix the problem.

Thanks!

-- Josh