[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Bugfix: org-agenda-open-link
From: |
Bert Burgemeister |
Subject: |
Re: [O] [PATCH] Bugfix: org-agenda-open-link |
Date: |
Sat, 19 Mar 2011 13:14:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Bert Burgemeister <address@hidden> writes:
> * Org-agenda.el (org-agenda-open-link): C-c C-o didn't open links
> inserted via the `%%( )' mechanism, affecting usability of
> `%%(org-bbdb-anniversaries).
>
> TINYCHANGE
> ---
>
>
> The bug was apparently introduced in commit
> ba1e90893d128d8004e4cb6763af692c5a6cd677.
>
> --
> Bert
>
>
>
> lisp/org-agenda.el | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 4b4dd68..123668c 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -6742,13 +6742,13 @@ at the text of the entry itself."
> (+ (point-at-bol)
> (or (org-get-at-bol 'prefix-length) 0)))))
> (cond
> - (buffer
> - (with-current-buffer buffer
> - (save-excursion
> - (save-restriction
> - (widen)
> - (goto-char marker)
> - (org-offer-links-in-entry arg prefix)))))
> + ((and buffer
> + (with-current-buffer buffer
> + (save-excursion
> + (save-restriction
> + (widen)
> + (goto-char marker)
> + (org-offer-links-in-entry arg prefix))))))
> ((or (org-in-regexp (concat "\\(" org-bracket-link-regexp "\\)"))
> (save-excursion
> (beginning-of-line 1)
Ok, perhaps I should complement my patch with a bug report.
%%(org-bbdb-anniversaries) inserts birthdays into the agenda that
contain links to the respective BBDB entry. These links are broken.
Here is a demonstration of the bug that doesn't require BBDB. Put the
following line into one of your agenda files:
%%((lambda () (concat "[[" "http" "://example.com" "]" "]")))
M-x org-agenda-list now includes decent links to http://example.com.
C-c C-o on one of them answers "No links".
--
Bert