[O] Bug: org-mobile-push fails, org-agenda-filter not defined [7.8.03 (release_7.8.03.5.gd3a45)]

[Charles Sebold]

This was happening yesterday and today; it appears that this happened
with the category filtering changes, but this is the first chance I've
gotten to do an org-mobile-push since then.

When I try org-mobile-push I get this:

------------------------------------------------------------------------
Debugger entered--Lisp error: (void-variable org-agenda-filter)
  (let ((org-agenda-buffer-name "*SUMO*") (org-agenda-filter org-agenda-filter) 
(org-agenda-redo-command org-agenda-redo-command)) (save-excursion 
(save-window-excursion (run-hooks (quote org-mobile-pre-push-hook)) 
(org-mobile-check-setup) (org-mobile-prepare-file-lists) (message "Creating 
agendas...") (let ((inhibit-redisplay t)) (org-mobile-create-sumo-agenda)) 
(message "Creating agendas...done") (org-save-all-org-buffers) (message 
"Copying files...") (org-mobile-copy-agenda-files) (message "Writing index 
file...") (org-mobile-create-index-file) (message "Writing checksums...") 
(org-mobile-write-checksums) (run-hooks (quote org-mobile-post-push-hook)))))
  (let ((a-buffer (get-buffer org-agenda-buffer-name))) (let 
((org-agenda-buffer-name "*SUMO*") (org-agenda-filter org-agenda-filter) 
(org-agenda-redo-command org-agenda-redo-command)) (save-excursion 
(save-window-excursion (run-hooks (quote org-mobile-pre-push-hook)) 
(org-mobile-check-setup) (org-mobile-prepare-file-lists) (message "Creating 
agendas...") (let ((inhibit-redisplay t)) (org-mobile-create-sumo-agenda)) 
(message "Creating agendas...done") (org-save-all-org-buffers) (message 
"Copying files...") (org-mobile-copy-agenda-files) (message "Writing index 
file...") (org-mobile-create-index-file) (message "Writing checksums...") 
(org-mobile-write-checksums) (run-hooks (quote org-mobile-post-push-hook))))) 
(redraw-display) (when (and a-buffer (buffer-live-p a-buffer)) (if (not 
(get-buffer-window a-buffer)) (kill-buffer a-buffer) (let ((cw 
(selected-window))) (select-window (get-buffer-window a-buffer)) 
(org-agenda-redo) (select-window cw)))))
  org-mobile-push()
  call-interactively(org-mobile-push nil nil)
------------------------------------------------------------------------

Nothing is defining org-agenda-filter, I guess.  I haven't used this
variable at all, I don't think.  git bisect and a fresh emacs -Q just
loading my org files, running (org-reload t), and (org-mobile-push)
gives me this:

------------------------------------------------------------------------
8c36e92f88b39f295a73f75ac10a84dc98648a96 is the first bad commit
commit 8c36e92f88b39f295a73f75ac10a84dc98648a96
Author: Bastien Guerry <address@hidden>
Date:   Sat Dec 31 17:10:44 2011 +0100

    Implement category filtering.

    * org-agenda.el (org-agenda-filter-preset): New alias.
    (org-agenda-filter-by-category): New command.
    (org-agenda-mode-map): Add the new command.
    (org-agenda-custom-commands-local-options): Add category
    filter preset.
    (org-agenda-mark-filtered-text): Mark both tag and filter
    overlays.
    (org-agenda-category-filter-preset): New variable.
    (org-finalize-agenda, org-agenda-redo)
    (org-agenda-filter-make-matcher, org-agenda-filter-apply):
    Handle both category and tag filters.
    (org-agenda-filter-show-all-tag): Rename from
    `org-agenda-filter-by-tag-show-all'.
    (org-agenda-filter-show-all-cat): New function.
    (org-agenda-set-mode-name): Show the category filter in the
    modeline.

    * org-faces.el (org-agenda-filter-category): New face.

    * org.texi (Agenda commands): Update documentation about the
    new category filtering feature.

    This feature has been requested by several people -- thanks
    to all of them for mentioning this possibility.

:040000 040000 1815512f6801fea74b11d2ae564e21e35c309734 
854738f490d1f3d246a0a005b95d4a0e9dff0afc M      doc
:040000 040000 16d656c0397c4dd9cf82f6d38d1ed5f7b3578bea 
696bf99b6204f18bf0d83a0bccb2edc9f98a9c75 M      lisp
------------------------------------------------------------------------

Emacs  : GNU Emacs 24.0.92.1 (i386-mingw-nt5.1.2600)
 of 2012-01-03 on CT-SEBOLDCR-T4C
Package: Org-mode version 7.8.03 (release_7.8.03.5.gd3a45)

current state:
==============
(setq
 org-export-blocks '((src org-babel-exp-src-block nil) (comment 
org-export-blocks-format-comment t)
                     (ditaa org-export-blocks-format-ditaa nil) (dot 
org-export-blocks-format-dot nil))
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point 
org-babel-execute-safely-maybe)
 org-src-fontify-natively t
 org-stuck-projects '("+LEVEL=2/-DONE" ("TODO" "NEXT" "NEXTACTION") ("info") "")
 org-mobile-before-process-capture-hook '((lambda nil
                                           (save-excursion (goto-char 
(point-min))
                                            (while (re-search-forward "\015$" 
nil t) (replace-match "" nil nil)))
                                           )
                                          )
 org-agenda-skip-scheduled-if-done t
 org-ditaa-jar-path "c:/source/org-mode/contrib/scripts/ditaa.jar"
 org-export-preprocess-before-selecting-backend-code-hook 
'(org-beamer-select-beamer-code)
 org-tab-first-hook '(org-hide-block-toggle-maybe 
org-src-native-tab-command-maybe
                      org-babel-hide-result-toggle-maybe)
 org-mobile-use-encryption t
 org-modules '(org-bbdb org-bibtex org-crypt org-docview org-gnus org-info 
org-jsinfo org-irc org-w3m org-odt)
 org-agenda-use-time-grid nil
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers 
org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-agenda-custom-commands '(("z" tags 
"memorize&daily|even|wednesday|memday04")
                              ("A" "Full Agenda" ((agenda "")))
                              ("7" "Full Weekly Agenda" ((agenda "" 
((org-agenda-span (quote week))))))
                              ("h" . "HOME + tag/TODO searches")
                              ("ha" "Full Agenda + Next Actions"
                               ((agenda) (todo "INBOX") (todo "NEXTACTION") 
(todo "TODO")))
                              ("hn" "Next Actions" ((todo "INBOX") (todo 
"NEXTACTION") (todo "TODO")))
                              ("ht" "Non-LCMS Tasks" ((tags-todo "-lcms")))
                              ("hp" "All Projects" ((todo "PROJECT") (todo 
"PROJWAITING") (todo "PROJVERIFY")))
                              ("R" "TeamMania tasks" ((tags-todo 
"+work+teammania")))
                              ("w" . "LCMS + tag/TODO searches")
                              ("wo" "LCMS Servicewise Open Tickets"
                               ((tags "+servicewise+ticket-status=\"Closed\"")))
                              ("wt" "LCMS tasks" ((tags-todo "+work+lcms")))
                              ("wn" "LCMS Next Actions"
                               ((agenda) (todo "INBOX") (todo "NEXTACTION")
                                (tags "+servicewise+ticket-status=\"Closed\"") 
(todo "TODO"))
                               ((org-agenda-files (quote ("~/org/lcms")))))
                              ("wp" "LCMS Unfinished Projects"
                               ((todo "PROJECT") (todo "PROJWAITING") (todo 
"PROJVERIFY"))
                               ((org-agenda-files (quote ("~/org/lcms")))))
                              ("ws" "SQL tasks" ((tags-todo "+work+sql")))
                              ("g" agenda "non-LCMS Agenda" ((org-agenda-files 
(quote ("~/org/gtd.org")))))
                              ("wd" agenda "LCMS Daily Agenda" 
((org-agenda-files (quote ("~/org/lcms"))))))
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-speed-command-hook '(org-speed-command-default-hook 
org-babel-speed-command-hook)
 org-export-preprocess-hook '(org-lparse-strip-experimental-blocks-maybe-hook)
 org-babel-pre-tangle-hook '(save-buffer)
 org-occur-hook '(org-first-headline-recenter)
 org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src 
org-babel-exp-inline-src-blocks))
 org-src-lang-modes '(("ocaml" . tuareg) ("elisp" . emacs-lisp) ("ditaa" . 
artist) ("asymptote" . asy)
                      ("dot" . fundamental) ("sqlite" . sql) ("calc" . 
fundamental) ("C" . c))
 org-deadline-warning-days 5
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-reveal-start-hook '(org-decrypt-entry)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-log-into-drawer t
 org-default-notes-file "~/org//process.org"
 org-export-preprocess-before-normalizing-links-hook 
'(org-remove-file-link-modifiers)
 org-export-preprocess-after-blockquote-hook 
'(org-export-odt-preprocess-latex-fragments
                                               
org-lparse-preprocess-after-blockquote-hook)
 org-agenda-span 'day
 org-latex-to-pdf-process '("xelatex -interaction nonstopmode %f" "xelatex 
-interaction nonstopmode %f")
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-export-latex-classes '(("crs-org-article"
                             
"\\documentclass[11pt,letter]{article}\n\\usepackage[T1]{fontenc}\n\\usepackage{fontspec}\n\\usepackage{graphicx}
 
\n\\defaultfontfeatures{Mapping=tex-text}\n\\usepackage{geometry}\n\\geometry{letter,
 textwidth=7.5in, textheight=10in,\n            marginparsep=7pt, 
marginparwidth=.6in}\n\\pagestyle{empty}\n\\title{}\n      
[NO-DEFAULT-PACKAGES]\n      [NO-PACKAGES]"
                             ("\\section{%s}" . "\\section*{%s}") 
("\\subsection{%s}" . "\\subsection*{%s}")
                             ("\\subsubsection{%s}" . "\\subsubsection*{%s}")
                             ("\\paragraph{%s}" . "\\paragraph*{%s}")
                             ("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
                            ("article" "\\documentclass[11pt]{article}" 
("\\section{%s}" . "\\section*{%s}")
                             ("\\subsection{%s}" . "\\subsection*{%s}")
                             ("\\subsubsection{%s}" . "\\subsubsection*{%s}")
                             ("\\paragraph{%s}" . "\\paragraph*{%s}")
                             ("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
                            ("report" "\\documentclass[11pt]{report}" 
("\\part{%s}" . "\\part*{%s}")
                             ("\\chapter{%s}" . "\\chapter*{%s}") 
("\\section{%s}" . "\\section*{%s}")
                             ("\\subsection{%s}" . "\\subsection*{%s}")
                             ("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
                            ("book" "\\documentclass[11pt]{book}" ("\\part{%s}" 
. "\\part*{%s}")
                             ("\\chapter{%s}" . "\\chapter*{%s}") 
("\\section{%s}" . "\\section*{%s}")
                             ("\\subsection{%s}" . "\\subsection*{%s}")
                             ("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
                            ("beamer" "\\documentclass{beamer}" 
org-beamer-sectioning))
 org-agenda-skip-deadline-if-done t
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-mode-hook '((lambda nil
                  (org-add-hook (quote change-major-mode-hook) (quote 
org-show-block-all) (quote append)
                   (quote local))
                  )
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook org-show-block-all 
append local] 5]
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook 
org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-agenda-mode-hook '(hl-line-mode)
 org-directory "~/org/"
 org-mobile-directory "~/My Documents/My Dropbox/MobileOrg/"
 org-from-is-user-regexp nil
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc 
org-beamer-auto-fragile-frames
                               org-beamer-place-default-actions-for-lists)
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-export-latex-quotes '(("fr" ("\\(\\s-\\|[[(]\\)\"" . "«~") 
("\\(\\S-\\)\"" . "~»")
                            ("\\(\\s-\\|(\\)'" . "'"))
                           ("en" ("\\(\\s-\\|[[(]\\)\"" . "``") ("\\(\\S-\\)\"" 
. "''")
                            ("\\(\\s-\\|(\\)'" . "`"))
                           )
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-todo-keywords '((sequence "INBOX(i)" "TICKLER(t!)" "|" "FILE(f@)" 
"CANCELED(k@)")
                     (sequence "TODO" "NEXTACTION(n)" "WAITING" "VERIFY" "|" 
"DONE" "REASSIGNED")
                     (sequence "DAILY(d)" "|" "DONEDLY" "UNSCHEDDLY(D)")
                     (sequence "WEEKLY(e)" "|" "DONEWKLY" "UNSCHEDWKLY(E)")
                     (sequence "MONTHLY(m)" "|" "DONEMNTHLY" "UNSCHEDMNTHLY(M)")
                     (sequence "QUARTERLY(q)" "|" "DONEQUARTERLY" 
"UNSCHEDQUTRLY")
                     (sequence "REQUEST(r!)" "REQWAITING(w@/!)" "REQVERIFY(v)" 
"|" "REQCLOSED(c!)"
                      "REQREASSIGNED(a@)")
                     (sequence "PROJECT(P!)" "PROJWAITING(W@/!)" 
"PROJVERIFY(V)" "|" "PROJCLOSED(C!)"
                      "PROJREASSIGNED(A@)")
                     )
 org-agenda-files '("~/org" "~/org/fiction" "~/org/reference" "~/org/personal" 
"~/org/gaming" "~/org/lcms")
 org-mobile-checksum-binary "sha1sum"
 org-drawers '("PROPERTIES" "CLOCK" "LOGBOOK")
 org-src-mode-hook '(org-src-babel-configure-edit-buffer 
org-src-mode-configure-edit-buffer)
 org-file-apps '(("\\.odc\\'" . system) ("\\.odf\\'" . system) ("\\.odi\\'" . 
system) ("\\.otp\\'" . system)
                 ("\\.odp\\'" . system) ("\\.otg\\'" . system) ("\\.odg\\'" . 
system) ("\\.ots\\'" . system)
                 ("\\.ods\\'" . system) ("\\.odm\\'" . system) ("\\.ott\\'" . 
system) ("\\.odt\\'" . system)
                 (auto-mode . emacs) ("\\.mm\\'" . default) ("\\.x?html?\\'" . 
default) ("\\.pdf\\'" . default))
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-babel-tangle-lang-exts '(("lisp" . "lisp") ("clojure" . "clj") 
("emacs-lisp" . "el"))
 org-babel-load-languages '((R) (clojure . t) (C) (ditaa . t) (dot) (emacs-lisp 
. t) (gnuplot) (haskell)
                            (latex) (lisp . t) (ocaml) (org . t) (perl) 
(python) (ruby) (screen) (sh) (sql . t)
                            (sqlite))
 org-use-fast-todo-selection 'prefix
 org-confirm-shell-link-function 'yes-or-no-p
 )