Re: [O] [PATCH] org-mobile agenda title

[Henning Weiss]

On Sat, Jan 28, 2012 at 3:41 PM, Bastien <address@hidden> wrote:

Hi Henning,

Henning Weiss <address@hidden> writes:

> I have been working on a patch for mobileorg-android that improves
> the displaying of the generated agendas.org file. The problem I'm
> having is that TITLE: fields of all entries are generated
> by concatenating the name and the matching criterion of an entry. The
> issue is discussed in further details here.
>
> I have tried to create a patch that removes the match criterions from
> the generated title entry and attached it below. This could
> potentially break other org-mobile clients and might not be the best
> way to solve this.
>
> What would it take to include this in orgmode?

The patch looks okay to me (I read the discussion you pointed to.)

Richard, would this patch break anything on your side?

Thanks,

--
 Bastien

Hi again,

I have a little revision to the patch to remove the matching criterion from "normal" (ie. non-block) agendas as well. See below.

best regards,

Henning Weiss

--- a/lisp/org-mobile.el

+++ b/lisp/org-mobile.el

@@ -574,7 +574,7 @@ The table of checksums is written to the file mobile-checksums."

                          (concat "<after>KEYS=" key " TITLE: "

                                  (if (and (stringp desc) (> (length desc) 0))

                                      desc (symbol-name type))

-                                 " " match "</after>"))

+                                 "</after>"))

                    settings))

        (push (list type match settings) new))

        ((or (functionp (nth 2 e)) (symbolp (nth 2 e)))

@@ -592,7 +592,7 @@ The table of checksums is written to the file mobile-checksums."

                (cons (list 'org-agenda-title-append

                            (concat "<after>KEYS=" gkey "#" (number-to-string

                                                      (setq cnt (1+ cnt)))

-                                   " TITLE: " gdesc " " match "</after>"))

+                                   " TITLE: " gdesc "</after>"))

                      settings))

          (push (list type match settings) new)))))

     (and new (list "X" "SUMO" (reverse new)