Re: [O] Org release 7.8.07 (BUGFIX-only release)

[Bastien]

Hi Achim,

Achim Gratz <address@hidden> writes:

> Bastien writes:
>> This is the version that will be merged into Emacs' trunk
>> by tomorrow.
>
> Please tag the release on maint so that Git reports the correct
> version.

Done.  (I tagged locally but forgot to push the tag.)

>>  Please report critical bugs using "URGENT"
>> in the subject line.
>
> All tests (except for R which I can't run due to lack of ESS) are clean
> on openSUSE/Tumbleweed with both Emacs 23.4 and 24.0.94.

Yes.

>> Thanks all for your help!
>
> I'm still getting these complaints about unprefixed / global variables
> w/ latest Emacs24 from trunk and fresh pull from master:
>
> In toplevel form:
> org.el:4871:1:Warning: global/dynamic var `date' lacks a prefix
>
> In toplevel form:
> org-agenda.el:95:1:Warning: global/dynamic var `date' lacks a prefix
>
> In toplevel form:
> org-bbdb.el:122:1:Warning: global/dynamic var `date' lacks a prefix
> org-bbdb.el:123:1:Warning: global/dynamic var `name' lacks a prefix

The problem with the `name' global variable is not in maint, I will 
have a look in master.

> In toplevel form:
> org-remember.el:280:1:Warning: global/dynamic var `annotation' lacks a prefix
> org-remember.el:281:1:Warning: global/dynamic var `initial' lacks a prefix

Yes, I know.  

This is not easy to fix, because the ̀date' global variable is set from
calendar.  Same for annotation and initial, which are set from
remember.el.  If you see a place where the fix is trivial (i.e. where my
assumption is false), please submit it.

> There is something going on in org-compat that I don't understand at all
> (note that find-library is not called at that poit at all, so there must
> be some macro expansion at work).  This is also in Emacs23:
>
> In org-find-library-name:
> org-compat.el:341:14:Warning: find-library called with 3 arguments, but
>     accepts only 1

Well, this is the culprit compatibility defun:

(defun org-find-library-name (library)
  (if (fboundp 'find-library-name)
      (file-name-directory (find-library-name library))
    ; XEmacs does not have `find-library-name'
    (flet ((find-library-name-helper (filename ignored-codesys)
                                     filename)
           (find-library-name (library)
            (find-library library nil 'find-library-name-helper)))  <<<<<
      (file-name-directory (find-library-name library)))))

I don't know how to circumvent this warning and btw I don't have this
warning in Emacs 24.0.94.1.

> Lastly, there's a function that has been obsoleted with Emacs24, so it
> should probably get a shim in org-compat to refer to one or the other
> definition based on Emacs version in a with-no-error form.
>
> In org-indent-mode:
> org-indent.el:212:11:Warning: `buffer-substring-filters' is an obsolete
>     variable (as of 24.1); use `filter-buffer-substring-functions' instead.
> org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
>     variable (as of 24.1); use `filter-buffer-substring-functions' instead.
> org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
>     variable (as of 24.1); use `filter-buffer-substring-functions' instead.

Yes.  The fix is not trivial.  Patch welcome!

Thanks,

-- 
 Bastien