Re: [O] Problems with (defvar foo) and Emacs 23

[Bastien]

Achim Gratz <address@hidden> writes:

> Bernt Hansen writes:
>> I can see the variable in the source defined as
>>
>> lisp/org-clock.el:(defvar org-clock-state) ;; dynamically scoped into this 
>> function
>>
>> but I don't get a variable definition with this code in emacs 23.2.1.
>
> You aren't supposed to get one, as this should have been pulling in a
> local variable defined elsewhere (from within another function).
>
>> If I change the definition to
>>
>> (defvar org-clock-state nil)
>>
>> then it works for me.
>
> Yes, but the bug introduced by renaming the variable is still there.
> You do get a variable, but not the one you're supposed to be scoping.

I fixed the problem with `org-clock-state'.  This should be `org-state'.

`state' is a local variable in many org.el functions, I renamed it to
`org-state' in org-clock.el and in "caller" sexp from org.el.  

> Again, the missing value is not the problem.  The problem arises when
> the variable name in the caller and the callee becomes different.  I'll
> let Bastien and Martyn sort that one out... :-)

Let's sort this out by slowly fixing problems that we can spot.

-- 
 Bastien