[O] org-program-exists vs executable-find

[Sebastien Vauban]

Hello,

While browsing the Org code, I've found the function `org-program-exists':

#+begin_src emacs-lisp
  (defun org-program-exists (program-name)
    "Checks whenever we can locate program and launch it."
    (if (member system-type '(gnu/linux darwin))
        (= 0 (call-process "which" nil nil nil program-name))))
#+end_src

It is used 3 times in `org-clock.el', nowhere else.

On the contrary, `executable-find' is used 10 times in the Org code base (in
4 different libraries).

Shouldn't we better use `executable-find' everywhere, instead of
`org-program-exists' (which, btw, fails on Windows systems, even when they
have the Cygwin `which' at their disposal)?

I'm ready to submit a patch for this.

Best regards,
  Seb

-- 
Sebastien Vauban