emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH 1/2] Simplify org-clocktable-indent-string.


From: Bastien
Subject: Re: [O] [PATCH 1/2] Simplify org-clocktable-indent-string.
Date: Fri, 20 Apr 2012 13:12:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

Hi Nicolas,

Nicolas Girard <address@hidden> writes:

> ---
>  lisp/org-clock.el |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 591f59c..be66ce6 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -2342,11 +2342,7 @@ from the dynamic block definition."
>  (defun org-clocktable-indent-string (level)
>    (if (= level 1)
>        ""
> -    (let ((str "\\__"))
> -      (while (> level 2)
> -     (setq level (1- level)
> -           str (concat str "___")))
> -      (concat str " "))))
> +    (concat "\\" (make-string (* 2 (1- level)) ?_ ) " ")))
>  
>  (defun org-clocktable-steps (params)
>    "Step through the range to make a number of clock tables."

The "simplification" does not produce the same output.

I rejected this patch.

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]