[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH v2 00/11] Takjuggler exporter improvements
From: |
Bastien |
Subject: |
Re: [O] [PATCH v2 00/11] Takjuggler exporter improvements |
Date: |
Thu, 16 Aug 2012 09:48:25 +0200 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) |
Hi Yann,
Yann Hodique <address@hidden> writes:
> here is a new version of the patch series.
Thanks.
> Changes are:
>
> - fixed commit messages format
Thanks for this effort -- not nitpicking, but there is room left for
small improvements.
- The summary line should be "org-taskjuggler.el: Sentence" (note the
.el after "org-taskjuggler").
- The ChangeLog entries should be sentences, starting with an uppercase
letter and ending with a full stop.
- It should be filled with C-x f 72 (or 70) then M-q.
- "Interactive functions" = "commands"
"custom variables" = "options"
This makes the entries shorter and tells immediatly what it is about.
All this because those entries are later on automatically parsed to get
added to Emacs. I review them manually, but fixing lots of entries
manually take a lot of time.
I'm having a branch with your changes -- I'll apply it when you confirm
you received the FSF papers.
Thanks!
--
Bastien
- Re: [O] [PATCH 07/10] org-taskjuggler: make project umbrella task optional, (continued)
- [O] [PATCH 08/10] org-taskjuggler: disambiguate "headline", as it's also a valid taskjuggler property, Yann Hodique, 2012/08/05
- [O] [PATCH 09/10] org-taskjuggler: allow reports definition from within the org file, Yann Hodique, 2012/08/05
- [O] [PATCH 10/10] org-taskjuggler: update doc to reflect latest changes, Yann Hodique, 2012/08/05
- Re: [O] [PATCH 00/10] Takjuggler exporter improvements, Bastien, 2012/08/05
- Re: [O] [PATCH 00/10] Takjuggler exporter improvements, Christian Egli, 2012/08/10
- [O] [PATCH v2 00/11] Takjuggler exporter improvements, Yann Hodique, 2012/08/15
- [O] [PATCH 04/10] org-taskjuggler: task with end-only is also a milestone (deadline), Yann Hodique, 2012/08/15
- Re: [O] [PATCH v2 00/11] Takjuggler exporter improvements,
Bastien <=
- [O] [PATCH v3 00/11] Taskjuggler exporter improvements, Yann Hodique, 2012/08/16
- [O] [PATCH v3 01/11] org-taskjuggler.el: Make task and resource properties customizable, Yann Hodique, 2012/08/16
- [O] [PATCH v3 03/11] org-taskjuggler.el: Make use of org properties, Yann Hodique, 2012/08/16
- [O] [PATCH v3 02/11] org-taskjuggler.el: Properly install local variables at export time, Yann Hodique, 2012/08/16
- [O] [PATCH v3 05/11] org-taskjuggler.el: Introduce a global header, for early macros, Yann Hodique, 2012/08/16
- [O] [PATCH v3 06/11] org-taskjuggler.el: Use project end date, if specified, Yann Hodique, 2012/08/16
- [O] [PATCH v3 04/11] org-taskjuggler.el: Fix milestone definition, Yann Hodique, 2012/08/16
- [O] [PATCH v3 07/11] org-taskjuggler.el: Make project umbrella task optional, Yann Hodique, 2012/08/16