[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] replace function name in org-bbdb
From: |
Rasmus |
Subject: |
Re: [O] [PATCH] replace function name in org-bbdb |
Date: |
Sat, 30 Mar 2013 16:51:42 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Bastien,
>> org-bbdb-anniversary was not working on my system before using bbdb3
>> from package.el (probably from MELPA...). This fixes this by renaming
>> a function which has been changed upstream.
>
> Looks good. Is there any versioning we can check in order to know
> what function's name will the users use?
bbdb3 hasn't been released yet. It's a moving target and I would
assume that people who use it are on the edge of the development. . .
The function(s) in question were renamed four months ago.
In any case this function will check that one has a sufficiently new
version of of bbdb (based on the change log I linked to in the commit
message). Should I make a local version of the bbdb field lookup
function and let the value be determined by the test below? I
unfortunately don't know what the version was called around 2012/12/25
so I test using the date, which may or may not be too fragile.
#+BEGIN_SRC emacs-lisp
(when (fboundp 'bbdb-version)
(string-match "\\([0-9]\\{4\\}/[0-9]\\{2\\}/[0-9]\\{2\\}\\)" (bbdb-version))
(version<=
(replace-regexp-in-string "/" "."
(match-string 1 (bbdb-version)))
"2012.12.25"))
#+END_SRC
Thanks,
Rasmus
--
May the Force be with you