[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] org-babel: two confirmations for org/HTML "macro"?
From: |
Eric Schulte |
Subject: |
Re: [O] org-babel: two confirmations for org/HTML "macro"? |
Date: |
Fri, 12 Apr 2013 16:37:27 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Bastien <address@hidden> writes:
> Hi Achim,
>
> Achim Gratz <address@hidden> writes:
>
>> Bastien writes:
>>> (Sorry, I pushed a fix for the compiler warning that your patch also
>>> solves.)
>>
>> Not in master, though?
>
> Yes -- pushed this morning.
>
>>> Achim Gratz <address@hidden> writes:
>>>
>>>> Since the test suite doesn't really test confirmation at all, it would
>>>> be nice if someone with a good variety of Babel calls could check if the
>>>> number of confirmations stay the same with and without the patch. I
>>>> don't think I have test cases that cover all possible combinations.
>>>
>>> Please let's go and apply this, that's the best way to have more
>>> people testing it. Thanks!
>>
>> Please wait for Eric to chime in.
>
> All right. Copying Eric for the heads-up.
>
After walking through this patch, it looks like it provides exactly the
correct behavior. Please go ahead and apply these changes.
Thanks Achim for the patch!
--
Eric Schulte
http://cs.unm.edu/~eschulte