Re: [O] Skim.app support for org-mac-link-grabber.el

[Ivan Andrus]

Just two comments from someone who didn't know org-mac-link-grabber existed 
until today (I'm gonna try it out) and hasn't (yet) contributed to org-mode.

1. It looks like it's actually enabled by default
2. You can detect whether it should be enabled by default with something like

(< 0 (length (shell-command-to-string
              "mdfind kMDItemCFBundleIdentifier == 
'net.sourceforge.skim-app.skim'")))

which will tell whether you have skim installed.  I haven't looked at 
org-mac-link-grabber to see if other similar changes could be made.  So the 
defcustom would be changed to

(defcustom org-mac-grab-Skim-app-p
  (< 0 (length (shell-command-to-string
                "mdfind kMDItemCFBundleIdentifier == 
'net.sourceforge.skim-app.skim'")))
  "Enable menu option [S]kim to grab page links from Skim.app"
  :tag "Grab Skim.app page links"
  :group 'org-mac-link-grabber
  :type 'boolean)

-Ivan

On May 12, 2013, at 12:29 PM, Daniil Frumin <address@hidden> wrote:

> Hi, all!
> 
> I use org-mac-link-grabber.el 
> <http://orgmode.org/worg/org-contrib/org-mac-link-grabber.html> almost every 
> day. However, it lacks support for an app that I'd like to use together with 
> org-mode. 
> 
> Skim.app is a light and fast PDF reader for Mac OS X with a note-taking 
> ability. I wrote a little patch for org-mac-link-grabber.el to support 
> grabbing links to documents.
> 
> What it does:
> 
> * Grabs not just the link to file, but a page
> 
> * Inserts the selected text as a description, if present. Otherwise
>  inserts "<filename>, p. <page #>"
> 
> * The shortcut is set to [S]
> 
> * Defines a new "skim" link type
> 
> It would be interesting to also add some support for importing notes from 
> Skim to org.
> 
> Since Skim.app is not present in clean OS X installs, by default support for 
> grabbing links from it is disabled. You can enable it by customizing group 
> `org-mac-link-grabber'.
> 
> So, maybe it's possible to get this patch into the tree? It's my first time 
> hacking on org (or even any major elisp extension), so it's probably that 
> I've messed up somewhere with a commit format or whatnot.
> 
> Cheers.
> 
> -- Daniil Frumin
> <0001-Adding-Skim.app-support-to-org-mac-link-grabber.el.patch>