[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [patch] ox-koma-letter.el: subject changes [2/4]
From: |
Alan Schmitt |
Subject: |
Re: [O] [patch] ox-koma-letter.el: subject changes [2/4] |
Date: |
Mon, 20 May 2013 17:49:07 +0200 |
User-agent: |
mu4e 0.9.9.5; emacs 24.3.1 |
Hello Rasmus,
Rasmus writes:
> This could be a problematic change. It changes the way :with-subject
> works. I've added changes to allow the subject style to be choose as
> a radio list with customize. The reason is that LaTeX becomes unhappy
> if it is not a supported value. If #+OPTIONS subject:t the default is
> used. If #+OPTIONS subject:my-crazy-string it tries that and most
> likely hell will break loose.
>
> Viktor, you're usage of ox-koma-letter.el is quite different from mine
> in that you rely (heavily?) on LCO files. If you could test this and
> see what you think of it it would be great. On my system it doesn't
> break anything vital but I might have missed something.
According to my very limited emacs-lisp knowledge, this looks fine. I
would suggest a couple renamings:
beavior -> behavior
fteropening -> afteropening
No-export -> noexport (so that it looks like the other ones).
Best,
Alan
[O] [patch] ox-koma-letter.el: credit [3/4], Rasmus, 2013/05/19