[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language. |
Date: |
Fri, 07 Jun 2013 14:35:43 +0200 |
Hello,
Rasmus <address@hidden> writes:
> Nicolas Goaziou <address@hidden> writes:
> is the attached patch better?
It is, thank you. Here is another round of comments.
> + (replace-match (mapconcat 'identity
> + (if language
> + (cond ((member language options)
> + (delete "AUTO") options)
> + ((member "AUTO" options)
> + (dotimes (n (length options)
> options)
> + (if (equal "AUTO" (nth n
> options))
> + (setf (nth n options)
> language))))
> + (t (append options (list
> language))))
> + (delete "AUTO" options))
I suggest to use something like this instead:
(mapconcat (lambda (option) (if (equal "AUTO" option) language option))
(cond ((member language options) (delete "AUTO" options))
((member "AUTO" options) options)
(t (append options (list language)))))
> - nil nil header 1))))))
> + t nil header 1)))))
Why do you need to use a non-nil FIXEDCASE argument here?
Regards,
--
Nicolas Goaziou
- Re: [O] [PATCH][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., (continued)
- Re: [O] [PATCH][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/03
- Re: [O] [PATCH][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Sebastien Vauban, 2013/06/03
- Re: [O] [PATCH][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/03
- Re: [O] [PATCH][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Sebastien Vauban, 2013/06/04
- Re: [O] [PATCH (new version)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/04
- Re: [O] [PATCH (new version)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Nicolas Goaziou, 2013/06/05
- Re: [O] [PATCH (new version)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Sebastien Vauban, 2013/06/06
- Re: [O] [PATCH (new version)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/06
- Re: [O] [PATCH (new version)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/06
- Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/06
- Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.,
Nicolas Goaziou <=
- Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/07
- Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Nicolas Goaziou, 2013/06/07
- Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/07
- Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Nicolas Goaziou, 2013/06/09
- Re: [O] [PATCH (v5)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/11
- Re: [O] [PATCH (v5)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Nicolas Goaziou, 2013/06/12
- Re: [O] [PATCH (v5)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language., Rasmus, 2013/06/12