Re: [O] Add figure/table numbers to HTML captions

[Nicolas Goaziou]

Hello,

Yoshinari Nomura <address@hidden> writes:

> I've split my work into these three commits:
>   0001-ox-html-add-figure-and-table-numbers-to-HTML-caption.patch
>   0002-ox-add-dictionary-entry-for-numbered-figures.patch
>   0003-ox-add-Japanese-translations-for-figures-and-tables.patch
>   (enclosed in the attachments)

Thanks for your work. Some minor comments below.

> commit a82e712c3d60d8b58e2cffe13d5cbcdfa25ede24
> Author: Yoshinari Nomura <address@hidden>
> Date:   Sat Jun 29 15:06:49 2013 +0900
>
>     ox: add Japanese translations for figures and tables
>     
>     * lisp/ox.el: (org-export-dictionary): Add Japanese translations for
>     figures and tables

You need to add TINYCHANGE at the end of your commit messages, since,
AFAIK, you haven't signed FSF papers yet.

> -        (let ((path (org-export-solidify-link-text path)) number)
> +        (let* ((path (org-export-solidify-link-text path)) number
> +               (caption-predicate
> +                (if (org-html--has-caption-p destination)
> +                    'org-html--has-caption-p))

You can remove this. Just use `org-html--has-caption-p' and replaces
references to `caption-predicate' below with it.

Otherwise, the patch looks good. Could you send the files as an
attachment? It will be easier for me to apply them.


Regards,

-- 
Nicolas Goaziou