[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [RFC] [patch] open/delete attachment with inherited directory
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [RFC] [patch] open/delete attachment with inherited directory |
Date: |
Tue, 17 Dec 2013 18:34:54 +0100 |
Hello,
Aaron Ecay <address@hidden> writes:
> I have some org files where each headline corresponds to an entry in a
> bibliography. The headlines each have attached to them a pdf file of
> the corresponding document. The attachment directory is set as a
> file-level property and inherited by the children (this is so that I can
> access the files easily also outside of org).
>
> In the current implementation of org-attach-{open,delete-one}, I am
> prompted to choose among all files in the attachment directory (i.e. all
> the pdfs of entries in the bibliography), not just the (usually single)
> file attached to the headline at point. I think the latter behavior
> makes more sense. The attached (heh) patch implements this change. Are
> there any comments?
Thanks for the patch.
I see one major problem, though. Org attach doesn't require to list
files attached to the entry (see `org-attach-file-list-property').
Therefore, `org-entry-get-multivalued-property' could return nil even
though there are attached files.
Regards,
--
Nicolas Goaziou