emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @


From: Nicolas Richard
Subject: Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]
Date: Thu, 20 Mar 2014 12:13:50 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

Le 20/03/2014 11:55, Bastien a écrit :
> Hi Nicolas,
> 
> Nicolas Richard <address@hidden> writes:
> 
>> Here's a patch. I can commit it if you like, but I don't want to do so
>> without some review (it's not as trivial a change as moving the
>> corresponding footnote to the other section).
> 
> I can't apply the patch, either on maint or on master, but by reading
> it carefully it looks good.

> Just add a missing full-stop at the end of the Changelog sentence "in
> its own section.", and perhaps use `C-x 4 a' from within the diff to
> include the section's name in the Changelog too.

Ok, I'll fix that and make sure it can be applied to master (I'm not
sure how I managed to miss that part.)

> PS: I didn't check carefully because I don't use `C' from magit, but
> I assume magit may be wrong in creating Changelogs.  We should report
> this to magit maintainers if this is true.

Indeed there usually is some difference between C (magit) and C-x 4 a. I
will have a look and report it when I get a chance.

-- 
Nico.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]