[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fix error prone babel table output format detection
From: |
Ian Kelling |
Subject: |
Re: [O] [PATCH] Fix error prone babel table output format detection |
Date: |
Sun, 04 May 2014 12:42:50 -0700 |
User-agent: |
Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux) |
Eric Schulte <address@hidden> writes:
> Hi Ian,
>
> You should use the `org-every' function here. Look at the source of
> that function to see code to efficiently perform this sort of check.
>
> Best,
>
Brilliant. Thank you. The updated patch below should be good.
-- >8 --
Subject: [PATCH] Fix error prone babel table output format detection
* lisp/ob-core.el: Test that all elements are in a list are lists or
'hline instead of just the first.
org-babel table output uses different formatting for a list of lists,
but detects it incorrectly causing an error. An example of a block
causing an error is an emacs lisp source block containing just 1 line:
'((1) 2)
---
lisp/ob-core.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 1348f04..4ddafaf 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2184,9 +2184,9 @@ code ---- the results are extracted in the syntax of the
source
((funcall proper-list-p result)
(goto-char beg)
(insert (concat (orgtbl-to-orgtbl
- (if (or (eq 'hline (car result))
- (and (listp (car result))
- (listp (cdr (car result)))))
+ (if (org-every
+ (lambda (el) (or (listp el) (eq el
'hline)))
+ result)
result (list result))
'(:fmt (lambda (cell) (format "%s" cell))))
"\n"))
(goto-char beg) (when (org-at-table-p) (org-table-align)))
--
1.7.10.4
- [O] [PATCH] Fix error prone babel table output format detection, Ian Kelling, 2014/05/01
- Re: [O] [PATCH] Fix error prone babel table output format detection, Achim Gratz, 2014/05/01
- Re: [O] [PATCH] Fix error prone babel table output format detection, Ian Kelling, 2014/05/01
- Re: [O] [PATCH] Fix error prone babel table output format detection, Ian Kelling, 2014/05/01
- Re: [O] [PATCH] Fix error prone babel table output format detection, Ian Kelling, 2014/05/01
- Re: [O] [PATCH] Fix error prone babel table output format detection, Ian Kelling, 2014/05/01
- Re: [O] [PATCH] Fix error prone babel table output format detection, Eric Schulte, 2014/05/04
- Re: [O] [PATCH] Fix error prone babel table output format detection,
Ian Kelling <=
- Re: [O] [PATCH] Fix error prone babel table output format detection, Eric Schulte, 2014/05/07
- Re: [O] [PATCH] Fix error prone babel table output format detection, Ian Kelling, 2014/05/09
- Re: [O] [PATCH] Fix error prone babel table output format detection, Bastien, 2014/05/21