Re: [O] [PATCH] Improve usage of odt content templates

[Christian Kellermann]

Hi!

* Nicolas Goaziou <address@hidden> [140519 18:16]:
> It is already possible to override the varible file-wise with:
> 
>   #+BIND: org-odt-content-template-file "somefile"
> 
> I'm not sure it is worth adding another keyword. OTOH, there's also
> ODT_STYLES_FILE and they are quite symmetric, so one could expect to be
> able to set both. But then, `org-odt-content-template-file''s docstring
> needs to be updated, and the feature should be documented in the manual.

I first thought about using ODT_STYLES_FILE in the list form and
pick out the content.xml from there, but maybe that's a bit unexpected
as one might use a different content than from the style.

But the control flow as it is now would need to be refactored to
make this a nice patch too.

I shall resend this patch with proper docstrings and manual patches
if you like.

> 
> Also, it should be
> 
>   (:odt-content-template-file "ODT_CONTENT_TEMPLATE_FILE" nil 
> org-odt-content-template-file t)

Ah of course.

> 
> > * Avoid inserting the document title as the first thing in the
> > document contents, as there already is a title set in a title page
> > in the template. As org-mode already sets the title data tag this
> > can be used in the template to generate the correct title. However
> > inserting the title as text is not desireable in that scenario.
> 
> I think this is a more general issue: should we implement an
> 
>   #+OPTIONS: title:nil
> 
> feature? I think it makes some sense since we already have date:nil and
> author:nil. In any case, keywords are not meant to be used for booleans.
> This should be an OPTIONS item.

I don't feel qualified to decide on this. I can provide the needed
patches though.

Thanks for your review!

Regards,

Christian

-- 
May you be peaceful, may you live in safety, may you be free from
suffering, and may you live with ease.