|
From: | Bastien |
Subject: | Re: [O] [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region) |
Date: | Fri, 23 May 2014 19:28:11 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Hi Alex, Alex Kosorukoff <address@hidden> writes: > Excluding mark-active will work, the result will be the same as after > my patch, except performance will not be the same. Excluding variable > requires filtering the list of variables which takes O(n) whereas my > patch takes O(1). Mark-active is nil before > org-capture-steal-local-variables because this is a new buffer. It > seems in this case setting it back to nil is faster than trying to > preserve its original value nil. I see what you mean but there is no performance issue here and not copying the value of mark-active is cleaner than setting it back to nil -- we never want to copy the value of the mark at all. -- Bastien
[Prev in Thread] | Current Thread | [Next in Thread] |