[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Adding new table rows/cols in a formula update
From: |
Dima Kogan |
Subject: |
Re: [O] Adding new table rows/cols in a formula update |
Date: |
Tue, 30 Sep 2014 22:44:29 -0700 |
>> Dima Kogan <address@hidden> writes:
>>
>> > Suppose I have this .org file:
>> >
>> > | |
>> > #+TBLFM: @1$2=5
>> >
>> > It's a 1x1 table with a formula. The formula sets a cell that's out of
>> > bounds in the table, so evaluating this formula results in an error.
>> > How set-in-stone is this behavior? I haven't dug too deeply into the
>> > code, but are there fundamental assumptions here? Would a patch that
>> > extends the table before applying such a formula be too naive in some
>> way?
>
> Subhan Michael Tindall <address@hidden> writes:
>
> I would include a customization variable to control this behavior, defaulting
> to whatever the current behavior is:
> IE:
> (setq org-calc-extend-file nil) default system behavior
> (setq org-calc-extend-file t) always silently extend rows
> (setq org-calc-extend-file "warn") issue warning in message buffer that line
> was extended
> (setq org-calc-extend-file "prompt") prompt user y/n on whether or not to
> extend column
OK. Patch attached.
>From 3b6581c647cb87f0d3e8cee94ce2fb1fb122d3fd Mon Sep 17 00:00:00 2001
From: Dima Kogan <address@hidden>
Date: Tue, 30 Sep 2014 22:36:21 -0700
Subject: [PATCH] Field formulas can now add columns as needed
The org-table-formula-make-new-cols customization controls whether and how this
is done
---
lisp/org-table.el | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/lisp/org-table.el b/lisp/org-table.el
index 7607ead..f2933ed 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -354,6 +354,16 @@ portability of tables."
(const :tag "Stick to hline" nil)
(const :tag "Error on attempt to cross" error)))
+(defcustom org-table-formula-make-new-cols nil
+ "Non-nil means that evaluation of a field formula can add new
+columns if an out-of-bounds field is being set."
+ :group 'org-table-calculation
+ :type '(choice
+ (const :tag "Setting an out-of-bounds field generates an error
(default)" nil)
+ (const :tag "Setting an out-of-bounds field silently adds columns as
needed" t)
+ (const :tag "Setting an out-of-bounds field adds columns as needed,
but issues a warning message" warn)
+ (const :tag "When setting an out-of-bounds field, the user is
prompted" prompt)))
+
(defgroup org-table-import-export nil
"Options concerning table import and export in Org-mode."
:tag "Org Table Import Export"
@@ -3125,7 +3135,22 @@ known that the table will be realigned a little later
anyway."
(while (setq eq (pop eqlname1))
(message "Re-applying formula to field: %s" (car eq))
(org-goto-line (nth 1 eq))
- (org-table-goto-column (nth 2 eq))
+ (let* ((column-target (nth 2 eq))
+ (column-count (progn (end-of-line)
+ (1- (org-table-current-column))))
+ (create-new-column
+ (and (> column-target column-count)
+ (or (eq org-table-formula-make-new-cols t)
+ (and
+ (eq org-table-formula-make-new-cols 'warn)
+ (progn
+ (org-display-warning "Out-of-bounds formula added
columns")
+ t))
+ (and
+ (eq org-table-formula-make-new-cols 'prompt)
+ (yes-or-no-p "Out-of-bounds formula. Add
columns?"))))))
+ (org-table-goto-column column-target nil create-new-column))
+
(org-table-eval-formula nil (nth 3 eq) 'noalign 'nocst
'nostore 'noanalysis))
--
2.0.0
- Re: [O] Adding new table rows/cols in a formula update,
Dima Kogan <=
- Re: [O] Adding new table rows/cols in a formula update, Nicolas Goaziou, 2014/10/01
- Re: [O] Adding new table rows/cols in a formula update, Dima Kogan, 2014/10/01
- Re: [O] Adding new table rows/cols in a formula update, Nick Dokos, 2014/10/01
- Re: [O] Adding new table rows/cols in a formula update, Dima Kogan, 2014/10/03
- Re: [O] Adding new table rows/cols in a formula update, Nicolas Goaziou, 2014/10/10
- Re: [O] Adding new table rows/cols in a formula update, Dima Kogan, 2014/10/10
- Re: [O] Adding new table rows/cols in a formula update, Bastien, 2014/10/11
- Re: [O] Adding new table rows/cols in a formula update, Nicolas Goaziou, 2014/10/11
- Re: [O] Adding new table rows/cols in a formula update, Dima Kogan, 2014/10/11
- Re: [O] Adding new table rows/cols in a formula update, Nicolas Goaziou, 2014/10/12