[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [patch, ox] #+INCLUDE resolves links
From: |
Rasmus |
Subject: |
Re: [O] [patch, ox] #+INCLUDE resolves links |
Date: |
Wed, 01 Oct 2014 23:27:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Hi,
Nicolas Goaziou <address@hidden> writes:
> It isn't very important, but you forgot full stops at the end of
> comments in the test file.
Fixed.
>> I want to discuss one more important potential issue before having the
>> patch applied. Currently, location is ignored if the included part is
>> not an env (line 3381) and not a block (3392). I'm not sure this is
>> right. I could do one of the following:
>>
>> 1. Nothing (current state)
>> 2. Throw an error if location and env or block are combined.
>> 3. Try to use location even if block is set. Recall, though, that
>> location is resolved using org-mode.
>> 4. Let location be a general regexp if env or block is non-nil.
>> But then we are breaking with the org file-link idea.
>> 5. Make location work for org files when env or block, otherwise
>> throw an error.
>>
>> WDYT?
>
> I think option 1 is perfect. If a block with org contents is needed, one
> can always do
>
> #+begin_center
> #+include: "file.org::*headline"
> #+end_center
>
> Block and environments are really meant for literal insertion, where
> locations do not apply.
Great! Less work.
We can always tune it later as necessary.
>> + (only-contents
>> + (and (string-match ":only-contents *?\\([^: \r\t\n]\\S-*\\)?"
>> value)
>
> Is the shy *? necessary?
No! Only the * is necessary to catch an implicit nil. Thanks.
Feel free to commit the attached patch if there's nothing else.
—Rasmus
--
Hooray!
0001-ox-Allow-file-links-with-INCLUDE-keyword.patch
Description: Text Data
- Re: [O] [patch, ox] #+INCLUDE resolves links, Nicolas Goaziou, 2014/10/01
- Re: [O] [patch, ox] #+INCLUDE resolves links,
Rasmus <=
- Re: [O] [patch, ox] #+INCLUDE resolves links, Xavier Garrido, 2014/10/02
- Re: [O] [patch, ox] #+INCLUDE resolves links, Rasmus, 2014/10/02
- Re: [O] [patch, ox] #+INCLUDE resolves links, Aaron Ecay, 2014/10/02
- Re: [O] [patch, ox] #+INCLUDE resolves links, Nicolas Goaziou, 2014/10/02
- Re: [O] [patch, ox] #+INCLUDE resolves links, Rasmus, 2014/10/02
- Re: [O] [patch, ox] #+INCLUDE resolves links, Achim Gratz, 2014/10/02
- Re: [O] [patch, ox] #+INCLUDE resolves links, Rasmus, 2014/10/02