[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH RFC] subtree archive hook?
From: |
Aaron Ecay |
Subject: |
Re: [O] [PATCH RFC] subtree archive hook? |
Date: |
Sun, 12 Oct 2014 19:13:24 +0100 |
User-agent: |
Notmuch/0.18.1+51~gbbbdf04 (http://notmuchmail.org) Emacs/24.4.50.2 (x86_64-unknown-linux-gnu) |
Hi Eric,
2014ko urriak 12an, Eric Abrahamsen-ek idatzi zuen:
>>
>> Can the above inlinetask thing also be moved into the hook? That
>> seems cleaner, and gives another demonstration of the usefulness of
>> the feature.
>
> Here's a patch that does it, though I'm a little more cautious about
> this since I only did a minimal test.
>
> Two things that worry me: 1) why is it called "remove-END-maybe" when it
> appears to remove the whole inlinetask, and 2) it its original habitat
> in org-attach, it came after the call to org-cut-subtree, meaning that
> it couldn't have operated on the subtree to be archived at all! Or am I
> misunderstanding something?
No, you’re not misunderstanding – I was. Indeed, the inline task stuff
has to come after the call to org-cut-subtree, so it’s not a candidate
for inclusion in the new hook.
(What happens is that org-cut-subtree removes the inline task headline and
any contents, leaving a bare *** END line. The latter is subsequently
cleaned up by the org-inlinetask-remove-END-maybe call.)
Sorry for the noise,
--
Aaron Ecay