[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Improve success message from org-remove-file.
From: |
Karl Fogel |
Subject: |
Re: [O] [PATCH] Improve success message from org-remove-file. |
Date: |
Tue, 25 Nov 2014 10:12:06 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Nicolas Goaziou <address@hidden> writes:
>Karl Fogel <address@hidden> writes:
>
>> The attached patch improves the interactive success message from
>> `org-remove-file'. Comments / suggestions welcome, of course; I've
>> tried to follow http://orgmode.org/worg/org-contribute.html here.
>
>Applied, thank you.
>
>I added "TINYCHANGE" at the end of your commit message.
Thanks for applying the change.
I didn't include "TINYCHANGE" on purpose. The guidelines say:
| If the change is a minor change made by a committer without
| copyright assignment to the FSF, the commit message should also
| contain the cookie TINYCHANGE (anywhere in the message). When we
| later produce the ChangeLog file for Emacs, the change will be
| marked appropriately.
However, I *do* have copyright assignment on file with the FSF (for
Emacs), so I interpreted the above as meaning I shouldn't include
"TINYCHANGE". What is the right thing to do here?
Best,
-Karl