|
From: | Nathaniel Flath |
Subject: | Re: [O] [PATH] Speedups to org-table-recalculate |
Date: | Sun, 7 Dec 2014 23:35:03 -0800 |
Nathaniel Flath <address@hidden> writes:
> Sorry, that was incorrect - real patches attached.
Thanks.
> +(defun org-table-message-once-per-second (t1 &rest args)
> + "If there has been more than one second since T1, display message.
> +ARGS are passed as arguments to the 'message' function. Returns
> +current time if a message is printed, otherwise returns t1.. If
> +T1 is nil, always messages."
> + (let ((curtime (current-time)))
> + (when (or (not t1) (< 0 (nth 1 (time-subtract curtime t1))))
> + (apply message args)
> + curtime))
> + t1)
The docstring seems incorrect, as the function always returns T1, no
matter if a message is printed or not.
> + (setq log-last-time
> + (org-table-message-once-per-second
> + (when all log-last-time)
Nitpick: (and all log-last-time)
> + (when all log-last-time)
Ditto.
> + (when all log-first-time)
Ditto.
Regards,
0001-org-table.el-org-table-recalculate-early-returns(1).patch
Description: Binary data
0001-org-table.el-org-table-recalculate-is-quieter.patch
Description: Binary data
[Prev in Thread] | Current Thread | [Next in Thread] |