Re: [O] [RFC] Display most recent log item in Agenda

[Eric Abrahamsen]

Nicolas Goaziou <address@hidden> writes:

> Eric Abrahamsen <address@hidden> writes:
>
>> I started with this approach for two reasons: 1) I thought collecting
>> the list items would be simpler, and as it became more and more
>> complicated, I didn't rethink the approach, and 2) collecting all the
>> items is the actual feature I was after (for future hackage), and the
>> agenda display was just a nice bonus.
>
> OK.
>
>> I'd like to keep the collection routine (even just for myself, if it's
>> not necessary for core), but you're right, the most-recent note display
>> could be done differently.
>
> Collecting is fine, but instead of using `org-log-beginning', I suggest
> to factor out parts you need (e.g. find the log drawer, if any).
>
> Note that if `org-log-into-drawer' is nil, you can only find all notes
> heuristically (they might be scattered across the section). In this
> case, finding the last note is safer.

I thought that's what `org-log-beginning' was for: finding where the
log-note list would be (drawer or no), if it exists. If users aren't
using `org-log-into-drawer', `org-log-beginning' should still go to the
spot where the list would be, right?

Then, if there's a list there, I take the first or last note (depending
on log-state-notes-reversed).

I don't know why the notes would be scattered across the section...

Slightly confused,
Eric