Re: [O] replace letf with cl-letf in org-mime

[Nicolas Goaziou]

Hello,

Eric Abrahamsen <address@hidden> writes:

> Subject: [PATCH] org-mime.el: Avoid use of letf/cl-letf

Thank you. Some comments follow.

> +    (let* ((mp (lambda (p)) (org-entry-get nil p 
> org-mime-use-property-inheritance))

It should be

  (mp (lambda (p) (org-entry-get ....)))

> +  (let ((bhook
> +      (lambda (body fmt)
> +        (let ((hook (intern (concat "org-mime-pre-"
> +                                    (symbol-name fmt)
> +                                    "-hook"))))
> +          (if (> (eval `(length ,hook)) 0)
> +              (with-temp-buffer
> +                (insert body)
> +                (goto-char (point-min))
> +                (eval `(run-hooks ',hook))
> +                (buffer-string))
> +            body))))

Not really related to the patch but the `eval' in the definition above
looks wrong. Shouldn't it be

  (> (length hook) 0)

and

  (run-hooks hook)

?


Regards,