[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed.
From: |
Puneeth Chaganti |
Subject: |
Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed. |
Date: |
Sun, 25 Oct 2015 07:54:20 +0530 |
Hi Rasmus,
On Sat, Oct 24, 2015 at 5:57 PM, Rasmus <address@hidden> wrote:
>
> However, you need to make sure that it only widens if ID is in the same
> buffer and outside of the narrow. In particular, when ID is in another
> file you shouldn’t widen. When it’s within the scope of the narrow it
> shouldn’t widen. This ALREADY seems to be the case.
I will fix the patch to widen only when the target location is not
within the narrow. But, I don't understand why we shouldn't be
widening if the target location is in a different buffer. Can you
explain?
> However, your patch doesn’t work for me in the following example, starting
> from emacs -q, adding /tmp/test.org (with the below content) to my agenda
> list and requiring org-id, org-narrow-to-subtree on foo, and then
> org-open-at-point on the link
I had patched `org-id-goto' and looks like clicking on links uses
`org-id-open'. I will resend a patch. I wonder if these two
functions can reuse common code.
--
Puneeth
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., (continued)
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Rasmus, 2015/10/23
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., John Kitchin, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Nicolas Goaziou, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Rasmus, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., John Kitchin, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Rasmus, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., John Kitchin, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Rasmus, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed.,
Puneeth Chaganti <=
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Nicolas Goaziou, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Nicolas Goaziou, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Rasmus, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/26
Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Matt Lundin, 2015/10/23