[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack
From: |
Aaron Ecay |
Subject: |
Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack |
Date: |
Wed, 04 Nov 2015 11:31:03 +0000 |
User-agent: |
Notmuch/0.20.2+65~gbd5504e (http://notmuchmail.org) Emacs/25.0.50.2 (x86_64-unknown-linux-gnu) |
Hi Jan,
2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen:
>
> * lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after
> expression
> evaluation.
> ---
> lisp/ob-calc.el | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/ob-calc.el b/lisp/ob-calc.el
> index e8b43e7..2656f27 100644
> --- a/lisp/ob-calc.el
> +++ b/lisp/ob-calc.el
> @@ -196,7 +196,9 @@ See `org-babel-calc-eval' for more info."
> (mapc #'org-babel-calc-eval-line (split-string text "[\n\r]"))
> (save-excursion
> (with-current-buffer (get-buffer "*Calculator*")
> - (calc-eval (calc-top 1)))))
> + (prog1
> + (calc-eval (calc-top 1)
Are you missing a close paren at the end of the above line? Also,
shouldn’t calc-eval take a string as an argument, not a lisp form? (I’m
asking based on the docstring, I don’t know the calc API at all).
--
Aaron Ecay
- Re: [O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere, (continued)
[O] [PATCH 7/9] org-notmuch: add date support to org-notmuch-store-link, Jan Malakhovski, 2015/11/03
[O] [PATCH 8/9] ob-calc: add more API, documentation and examples so that it can be used in tables, Jan Malakhovski, 2015/11/03
[O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Jan Malakhovski, 2015/11/03
- Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack,
Aaron Ecay <=
Re: [O] [PATCH v2 0/9] mail, clock and calc changes, Aaron Ecay, 2015/11/04