[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Errors get suppressed by org-babel-execute-src-block
From: |
Aaron Ecay |
Subject: |
Re: [O] Errors get suppressed by org-babel-execute-src-block |
Date: |
Wed, 10 Feb 2016 20:23:44 +0000 |
User-agent: |
Notmuch/0.21+33~g570c0ae (http://notmuchmail.org) Emacs/25.0.50.2 (x86_64-unknown-linux-gnu) |
Hi Gary,
2016ko otsailak 8an, Gary Oberbrunner-ek idatzi zuen:
>
> org-babel-execute-src-block has a big unwind-protect that basically eats
> all errors inside it. I don't think it used to do that.
The unwind-protect exists since 2010, so you’re probably mistaken about
that (depending on your frame of reference for “used to”...)
That said, the code in question seems very questionable to me. First
of all, the unwind-protect should not be needed at all, due to the use
of (f)let (IOW, if the unwind-protect was ever needed, it was to paper
over a bug in emacs which should no longer exist). Secondly, in 2012
commit 57104f9f changed an “org-flet” to a “let” in this function,
which is incorrect (since elisp is a lisp-2). So the whole thing has
been effectively a no-op since then.
I’d like to install the attached patch to master, if there are no
objections. That should resolve your concern as well as cleaning up the
dead code.
Aaron
--
Aaron Ecay
0001-ob-core-remove-cruft.patch
Description: Text Data
- [O] Errors get suppressed by org-babel-execute-src-block, Gary Oberbrunner, 2016/02/08
- Re: [O] Errors get suppressed by org-babel-execute-src-block,
Aaron Ecay <=
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Nicolas Goaziou, 2016/02/10
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Nick Dokos, 2016/02/11
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Aaron Ecay, 2016/02/12
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Nick Dokos, 2016/02/12
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Aaron Ecay, 2016/02/14
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Nicolas Goaziou, 2016/02/20
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Nick Dokos, 2016/02/20
- Re: [O] Errors get suppressed by org-babel-execute-src-block, Aaron Ecay, 2016/02/22