[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [BUG] Dynamic scoping of project-plist in preparation-function
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [BUG] Dynamic scoping of project-plist in preparation-function |
Date: |
Wed, 22 Jun 2016 15:34:17 +0200 |
Hello,
Arun Isaac <address@hidden> writes:
>> 2. Require preparation functions to accept one parameter, the project
>> plist.
>
> I think adding project-plist as a parameter to preparation functions is
> definitely more elegant.
Done in 5cd793c.
> But, I also came across this old thread where it was noted that making
> project-plist a proper parameter, instead of it being dynamically scoped
> into the preparation function, would break a lot of code.
Bad code deserves to be broken anyway.
More seriously, the fix is trivial, so I don't think this is an issue.
Thank you for the feedback.
Regards,
--
Nicolas Goaziou