|
From: | John Kitchin |
Subject: | Re: [O] links-9.0 v3 |
Date: | Mon, 18 Jul 2016 11:20:30 -0400 |
User-agent: | mu4e 0.9.16; emacs 25.1.50.1 |
Nicolas Goaziou writes: > Hello, > > John Kitchin <address@hidden> writes: > >> Here are my current suggestions for the org-link 9.0. > > Thank you. I think I fixed the points you made in the previous email. > >> Let me know what the best way to send these might be. It looks like it >> might be 21 patches right now. > > AFAIU, many among them introduce code that no longer exists in the final > draft. It would be nice to make them disappear, using interactive > rebasing, as suggested earlier in this thread. I am not sure what you mean for this. Let me know if it isn't fixed in the attached patches. I thought I had squashed everything into a concise history. > > If that's not possible, just send them over here, I'll apply them. > > BTW sent patch doesn't seem to include an option handler. Am I missing > something? What do you mean by an option handler? Do you mean for this file:path::option I think this code below (which should be in the patches) handles the option correctly. (defun org--open-file-link (path app) "Open PATH using APP. PATH is from a file link, and can have the following syntax: [[file:~/code/main.c::255]] [[file:~/xx.org::My Target]] [[file:~/xx.org::*My Target]] [[file:~/xx.org::#my-custom-id]] [[file:~/xx.org::/regexp/]] APP is '(4) to open the PATH in Emacs, or 'system to use a system application." (let* ((fields (split-string path "::")) (option (and (cdr fields) (mapconcat #'identity (cdr fields) "")))) (apply #'org-open-file (car fields) app (cond ((not option) nil) ((string-match-p "\\`[0-9]+\\'" option) (list (string-to-number option))) (t (list nil (org-link-unescape option))))))) > > Regards,
0001-Create-org-link-parameters.patch
Description: Text Data
0002-Remove-org-link-protocols-variable.patch
Description: Text Data
0003-Get-the-complete-function-from-org-link-parameters.patch
Description: Text Data
0004-Update-org-activate-plain-links.patch
Description: Text Data
0005-Update-org-activate-bracket-links.patch
Description: Text Data
0006-Make-plain-and-bracketed-link-properties-stick.patch
Description: Text Data
0007-Update-bbdb-link-definition.patch
Description: Text Data
0008-Update-bibtex-link-definition.patch
Description: Text Data
0009-Update-docview-link-definition.patch
Description: Text Data
0010-Update-eshell-link-definition.patch
Description: Text Data
0011-Update-gnus-link-definition.patch
Description: Text Data
0012-Update-info-link-definition.patch
Description: Text Data
0013-Update-irc-link-definition.patch
Description: Text Data
0014-Update-mhe-link-definition.patch
Description: Text Data
0015-Update-rmail-link-definition.patch
Description: Text Data
0016-Update-w3m-link-definition.patch
Description: Text Data
0017-Update-the-id-link-with-org-link-set-parameters.patch
Description: Text Data
0018-Update-the-texinfo-for-link-parameters-documentation.patch
Description: Text Data
0019-Update-NEWS-with-link-announcement.patch
Description: Text Data
0020-Update-the-contrib-manual.patch
Description: Text Data
-- Professor John Kitchin Doherty Hall A207F Department of Chemical Engineering Carnegie Mellon University Pittsburgh, PA 15213 412-268-7803 @johnkitchin http://kitchingroup.cheme.cmu.edu
[Prev in Thread] | Current Thread | [Next in Thread] |