Re: [O] Add support for sqsh sql src blocks

[Nicolas Goaziou]

Hello,

MaDhAt2r <address@hidden> writes:

> ob-sql-el: Add support for `sqsh' as an SQL engine

Thank you for the patch. Some comments follow.

> -      (`mssql "SET NOCOUNT ON
> +         ((or `mssql `sqsh ) "SET NOCOUNT ON

There is a spurious white space above.

> -       (org-babel-expand-body:sql body params)))
> +       (org-babel-expand-body:sql body params)
> +       ;; sqsh requires `go' inserted at EOF
> +       (if (equal (intern engine) `sqsh)
> +           "\ngo"
> +         "")
> +       ))

  ;; sqsh requires "go" inserted at EOF.

also, do not leave dangling parenthesis at the end of the expression
above.

> +  (cond
> +      ((equal (intern engine) 'sqsh)
> +    (org-table-import out-file '(4))
> +    )
> +   (t
> +    (org-table-import out-file '(16))
> +    )
> +   )

See above about parenthesis.

Eventually, could you write a proper commit message, e.g.

  * lisp/ob-sql.el (org-babel-sql-dbstring-sqsh): New function
  (....): Added ....

Regards,

-- 
Nicolas Goaziou