[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Bug: org-eww-copy-for-org-mode Empty Link problem + easy fix [9.
From: |
Marco Wahl |
Subject: |
Re: [O] Bug: org-eww-copy-for-org-mode Empty Link problem + easy fix [9.0.4 (9.0.4-elpaplus @ /home/andrea/.emacs.d/elpa/org-plus-contrib-20170124/)] |
Date: |
Sun, 12 Feb 2017 09:27:57 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Hello Andrea,
thanks for your bug report and your suggestion to fix the bug.
[...]
> The error is due to the presence of input forms (e.g., in
> www.indeed.co.uk where you can add the job you are looking for), that
> are considered like urls by this function [1]. When the input form is
> passed to org-make-link-string, org-make-link-string complains that the
> link is empty.
>
> Now I solved this by adding an if statement that makes the link only if
> the info passed is not nil [2], but maybe someone knows a better check
> for org-eww-goto-next-url-property-change than the one using 'shr-url?
I committed a fix to maint and master. Concretely I simplified your
code to essentially one additional if case.
You are referenced in the commit-message as reporter.
Best regards,
Marco