Re: [O] Bug in Recent Agenda Mod

[Marco Wahl]

Marco Wahl <address@hidden> writes:

> Ian Dunn <address@hidden> writes:
>
>> Commit d262ae53c966c7a745c0fa779149f9eb7486333d "org-agenda: Fix agenda 
>> standard name when going unsticky" sets org-agenda-buffer-name to "*Org 
>> Agenda*" if not in sticky.
>>
>> However, org-agenda-redo sets org-agenda-sticky to nil before redoing the 
>> agenda command.
>>
>> Steps to Reproduce:
>>
>> 1. Turn on org-agenda-sticky
>> 2. Execute any agenda command that only involves org-agenda-list
>>    - Agenda is in buffer *Org Agenda(CMD)* (ex. *Org Agenda(d:)*)
>> 3. Press 'g' (org-agenda-redo)
>>    - Agenda is now in *Org Agenda*
>>
>> The included patch fixes this for sticky redo, and will have no effect for 
>> anything other than a sticky redo.
>>
>> --
>> Ian Dunn
>>
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index b618653d5..04e6685b5 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -4076,6 +4076,7 @@ items if they have an hour specification like [h]h:mm."
>>    (catch 'exit
>>      (setq org-agenda-buffer-name
>>        (or org-agenda-buffer-tmp-name
>> +          (and org-agenda-doing-sticky-redo org-agenda-buffer-name)
>>            (if org-agenda-sticky
>>                (cond ((and org-keys (stringp org-match))
>>                       (format "*Org Agenda(%s:%s)*" org-keys org-match))
>
> Good catch, good fix AFAICT.  Thanks.
>
> May I add this line with a commit message referencing you as the
> originator?  (I have not found you in the contributors list.)

I just committed your fix.


Ciao