[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Backward incompatible outline-invisible-p change in emacs master
From: |
Bastien Guerry |
Subject: |
Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org |
Date: |
Wed, 14 Jun 2017 19:02:13 +0200 |
User-agent: |
Gnus/5.130014 (Ma Gnus v0.14) Emacs/26.0 (gnu/linux) |
Hi Kaushal,
thanks for putting me in the loop.
Kaushal Modi <address@hidden> writes:
> I also find an org-invisible-p2 function, but it's not clear why it
> does a (backward-char 1) before doing invisibility check.. and that
> too eventually relies on outline-visible-p. (Turns out this function
> has a long history: http://orgmode.org/cgit.cgi/org-mode.git/commit/?
> id=93a4128a6fe47b4e05c0a7cb3ec14878b41d6000 )
The question is: why this patch in the first place? Paul authored it
and I committed it, so I should know--but I don't. Maybe Paul know or
you know better?
> Here's a patch for the above proposed solution.
This looks fine, but I'd rather revert the faulty Emacs commit if
it is not necessary.
Until Paul enlighten us, I'll have a deeper look.
Thanks,
--
Bastien
- Re: [O] 6 failing tests on master branch, (continued)
- Re: [O] 6 failing tests on master branch, Kaushal Modi, 2017/06/09
- Re: [O] 6 failing tests on master branch, Kaushal Modi, 2017/06/09
- Re: [O] 6 failing tests on master branch, Michael Albinus, 2017/06/09
- Re: [O] 6 failing tests on master branch, Kaushal Modi, 2017/06/09
- Re: [O] 6 failing tests on master branch, Nicolas Goaziou, 2017/06/09
- Re: [O] 6 failing tests on master branch, Kaushal Modi, 2017/06/09
- Re: [O] 6 failing tests on master branch, Nicolas Goaziou, 2017/06/09
- Re: [O] 6 failing tests on master branch, Kaushal Modi, 2017/06/09
- [O] Backward incompatible outline-invisible-p change in emacs master for Org (Was: 6 failing tests on master branch), Kaushal Modi, 2017/06/14
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org (Was: 6 failing tests on master branch), Kaushal Modi, 2017/06/14
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org,
Bastien Guerry <=
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org, Kaushal Modi, 2017/06/14
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org, Paul Rankin, 2017/06/14
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org, Bastien Guerry, 2017/06/15
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org, Kaushal Modi, 2017/06/15
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org, Bastien Guerry, 2017/06/15
- Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org, Kaushal Modi, 2017/06/15