|
From: | Takaaki Ishikawa |
Subject: | Re: [O] [PATCH] Add a custom list in org-mac-link.el |
Date: | Fri, 16 Jun 2017 03:38:55 +0900 |
> +(defcustom org-mac-link-descriptors
> + `(("F" "inder" org-mac-finder-insert-selected ,org-mac-grab-Finder-app-p)
> + ("m" "ail" org-mac-message-insert-selected ,org-mac-grab-Mail-app-p)
> + ("d" "EVONthink Pro Office" org-mac-devonthink-item-insert-selected
> + ,org-mac-grab-devonthink-app-p)
> + ("o" "utlook" org-mac-outlook-message-insert-selected ,org-mac-grab-Outlook-app-p)
> + ("a" "ddressbook" org-mac-addressbook-insert-selected ,org-mac-grab-Addressbook-app- p)
> + ("s" "afari" org-mac-safari-insert-frontmost-url ,org-mac-grab-Safari-app-p)
> + ("f" "irefox" org-mac-firefox-insert-frontmost-url ,org-mac-grab-Firefox-app-p)
> + ("v" "imperator" org-mac-vimperator-insert-frontmost-url ,org-mac-grab-Firefox+ Vimperator-p)
> + ("c" "hrome" org-mac-chrome-insert-frontmost-url ,org-mac-grab-Chrome-app-p)
> + ("e" "evernote" org-mac-evernote-note-insert-selected ,org-mac-grab-Evernote-app-p)
> + ("t" "ogether" org-mac-together-insert-selected ,org-mac-grab-Together-app-p)
> + ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)
> + ("A" "crobat" org-mac-acrobat-insert-page ,org-mac-grab-Acrobat-app-p))
> + "Descriptors to select an application."
Could you expand the docstring a bit? What is a descriptor, what type of
data structure is it?
> + :tag "A list of descriptors"
> + :group 'org-mac-link'
> + :type 'symbol)
The :type value is wrong. You need a composite type here.
Is it useful to let the °descriptors' binding? We could simply replace
`descriptors' with `org-mac-link-descriptors' in the `let' body. WDYT?
[Prev in Thread] | Current Thread | [Next in Thread] |