[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sq
|
From: |
Pierre Téchoueyres |
|
Subject: |
Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql. |
|
Date: |
Thu, 15 Mar 2018 19:34:39 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Nicolas Goaziou <address@hidden> writes:
Hi Nicolas,
> ...
> It looks good.
>
> I added two spaces at the end of sentences and pushed it.
> ...
I'm sorry I did a mistake in the previous patch. There is an
inconsistency between the code in `org-babel-sql-dbstring-oracle' and
the example provided in the ORG-NEWS file.
So I attached two patches:
- the first (0001-ORG-NEWS-...) correct the example in order to match to the
code,
- the second (0001-ob-sql.el...) correct the codein order to match to the
example.
Personnaly I prefer the last as it match better with the habits of
thoses who uses Oracle's products (We talk almost ever in term of
database than in term of servers).
But it's up to you.
0001-ORG-NEWS-Correct-Oracle-connection-and-usage-for-ob.patch
Description: 0001-ORG-NEWS-Correct-Oracle-connection-and-usage-for-ob.patch
0001-ob-sql.el-Improve-Oracle-connection-and-usage-for-ob.patch
Description: 0001-ob-sql.el-Improve-Oracle-connection-and-usage-for-ob.patch