[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH v2 0/3] org-sbe fixes
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH v2 0/3] org-sbe fixes |
Date: |
Sun, 25 Mar 2018 23:06:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
Vladimir Panteleev <address@hidden> writes:
> One ugly fix would be to patch over this by checking for some common
> lisp forms that result in a list, such as (list ...) and (quote ...),
> and treat the remaining ones in a backwards-compatible way. However,
> the more time I spend on org-sbe, the more I think that perhaps
> a better approach would be to deprecate org-sbe (or outright remove
> it, I could argue that due to the overwhelming number of flaws its
> mere presence is downright harmful), and replace it with something
> more sensible: a function (not macro) defined somewhere other than
> ob-table (because it is not specific to tables) without any of the
> crazy string escaping logic.
>
> What do you think?
I have reverted your changes from maint.
I agree "org-sbe" should be rewritten. However, it is specific to tables
because it is meant to be used in a TBLFM line. Its replacement could
live in "org-table.el", though.
Regards,
--
Nicolas Goaziou 0x80A93738
- Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments, (continued)
- Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments, Vladimir Panteleev, 2018/03/18
- Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments, Nicolas Goaziou, 2018/03/18
- [O] [PATCH v2 0/3] org-sbe fixes, Vladimir Panteleev, 2018/03/18
- [O] [PATCH v2 2/3] ob-table: Fix org-sbe's handling of list arguments, Vladimir Panteleev, 2018/03/18
- [O] [PATCH v2 1/3] ob-table: Fix org-sbe's handling of quotes in cell values, Vladimir Panteleev, 2018/03/18
- [O] [PATCH v2 3/3] ob-table: Mention passing ranges as lists in org-sbe's documentation, Vladimir Panteleev, 2018/03/18
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Nicolas Goaziou, 2018/03/19
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Alan Schmitt, 2018/03/25
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Nicolas Goaziou, 2018/03/25
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Vladimir Panteleev, 2018/03/25
- Re: [O] [PATCH v2 0/3] org-sbe fixes,
Nicolas Goaziou <=
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Vladimir Panteleev, 2018/03/25
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Nicolas Goaziou, 2018/03/26
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Vladimir Panteleev, 2018/03/26
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Nicolas Goaziou, 2018/03/26
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Vladimir Panteleev, 2018/03/26
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Nicolas Goaziou, 2018/03/27
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Alan Schmitt, 2018/03/26
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Nicolas Goaziou, 2018/03/26
- Re: [O] [PATCH v2 0/3] org-sbe fixes, Bastien, 2018/03/26
[O] [PATCH 3/3] ob-table: Mention passing ranges as lists in org-sbe's documentation, Vladimir Panteleev, 2018/03/08