Re: [O] [PATCH] support insert link without write result to :file link

[stardiviner]

Hi, Nicolas, I have problem in my code. Even after many times and 5 hourse Edebug on ob-core.el code. Still can't find out where is wrong. After Edebug, just know somewhere is wrong. here is my info:

- [ ] probelm is on ~org-babel-merge-params~, ~info~ is generated from it, but it removed ~link~ in ~:results~.
- [ ] org-babel-execute-src-block
  - [ ] (org-babel-get-src-block-info)
    - [ ] (let* ((info .. (apply #'org-babel-merge-params ...))))  -> info -> :results file replace (been removed here)
      - because ~:results link file replace~ are merged into ~:results file replace~?
        - where does the ~file~ comes from?
          - from ~:file~ header argument?
            - which function get this?
      - [ ] org-babel-process-params info

I added my latest patches in attachment (include test, and added your suggested modification). Can you help me on my code?

On 03/27/2018 02:26 PM, Nicolas Goaziou wrote:

Hello,

stardiviner <address@hidden> writes:

I added this patch to handle posted question case.

This will improve Org-mode links with org-babel resulta lot. Make
Org-mode can insert link as user want at many places.

Hope can be merged.

Thank you.

However, before thinking about merging it, it requires documentation and
tests. You also need to update `org-babel-common-header-args-w-values'.

Also, there are still failing tests from the last change to :results
behaviour in master, if you ever have time to look into it.

Regards,

0001-ob-core.el-org-babel-execute-src-block-support-resul.patch
Description: Text Data

0002-ob-core.el-add-graphics-to-result-type.patch
Description: Text Data