[O] [PATCH] clocktable thinks Oct 29 is Oct 28 [9.1.14 (release_9.1.14-1012-g643481 @ /home/unhammer/src/org-mode/lisp/)]

[Kevin Brubeck Unhammer]

The attached patch solves this, as far as I can tell.

I have signed the FSF copyright papers.

best regards,
Kevin Brubeck Unhammer


From e818cd5d1c651a516a0e791a10d91fe1e310cde9 Mon Sep 17 00:00:00 2001
From: Kevin Brubeck Unhammer <address@hidden>
Date: Thu, 1 Nov 2018 13:59:09 +0100
Subject: [PATCH] org-clock: Handle DST in clocktable

* lisp/org-clock.el (org-clocktable-steps): new fn
  org-clocktable-increment-day to add/subtract days that are not
  exactly 24 hours
* testing/lisp/test-org-clock.el (test-org-clock/clocktable/step): Add
  test for DST.
---
 lisp/org-clock.el              | 27 +++++++++++++++++++--------
 testing/lisp/test-org-clock.el | 21 ++++++++++++++++++++-
 2 files changed, 39 insertions(+), 9 deletions(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 420fdadfe..6292a259f 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -2681,6 +2681,15 @@ LEVEL is an integer.  Indent by two spaces per level 
above 1."
   (if (= level 1) ""
     (concat "\\_" (make-string (* 2 (1- level)) ?\s))))
 
+(defun org-clocktable-increment-day (ts &optional n)
+  "Increment day in TS by N (defaulting to 1).
+The TS argument has the same type as the return values of
+`float-time' or `current-time'."
+  (let ((tsd (decode-time ts)))
+    (cl-incf (nth 3 tsd) (or n 1))
+    (setf (nth 8 tsd) nil) ; no time zone: increasing day skips one whole day
+    (apply 'encode-time tsd)))
+
 (defun org-clocktable-steps (params)
   "Step through the range to make a number of clock tables."
   (let* ((ts (plist-get params :tstart))
@@ -2688,7 +2697,6 @@ LEVEL is an integer.  Indent by two spaces per level 
above 1."
         (ws (plist-get params :wstart))
         (ms (plist-get params :mstart))
         (step0 (plist-get params :step))
-        (step (cdr (assq step0 '((day . 86400) (week . 604800)))))
         (stepskip0 (plist-get params :stepskip0))
         (block (plist-get params :block))
         cc tsb)
@@ -2715,16 +2723,19 @@ LEVEL is an integer.  Indent by two spaces per level 
above 1."
          (if (eq step0 'week)
              (let ((dow (nth 6 (decode-time (seconds-to-time ts)))))
                (if (<= dow ws) ts
-                 (- ts (* 86400 (- dow ws)))))
+                 (org-clocktable-increment-day ts ; decrement
+                                               (- ws dow))))
            ts))
     (while (< tsb te)
       (unless (bolp) (insert "\n"))
-      (let ((start-time (seconds-to-time (max tsb ts))))
-       (cl-incf tsb (let ((dow (nth 6 (decode-time (seconds-to-time tsb)))))
-                      (if (or (eq step0 'day)
-                              (= dow ws))
-                          step
-                        (* 86400 (- ws dow)))))
+      (let* ((start-time (seconds-to-time (max tsb ts)))
+            (dow (nth 6 (decode-time (seconds-to-time tsb))))
+            (days-to-skip (cond ((eq step0 'day) 1)
+                                ;; else 'week:
+                                ((= dow ws) 7)
+                                (t (- ws dow)))))
+       (setq tsb (time-to-seconds (org-clocktable-increment-day tsb
+                                                                days-to-skip)))
        (insert "\n"
                (if (eq step0 'day) "Daily report: "
                  "Weekly report starting on: ")
diff --git a/testing/lisp/test-org-clock.el b/testing/lisp/test-org-clock.el
index abb3637bd..ddc135669 100644
--- a/testing/lisp/test-org-clock.el
+++ b/testing/lisp/test-org-clock.el
@@ -977,7 +977,26 @@ CLOCK: [2017-12-27 Wed 08:00]--[2017-12-27 Wed 16:00] =>  
8:00"
            (let ((system-time-locale "en_US"))
              (test-org-clock-clocktable-contents
                  (concat ":step day :tstart \"<2017-12-25 Mon>\" "
-                         ":tend \"<2017-12-27 Wed 23:59>\" :stepskip0 t")))))))
+                         ":tend \"<2017-12-27 Wed 23:59>\" :stepskip0 t"))))))
+  ;; Regression test: Respect DST
+  (should
+   (equal "
+Daily report: [2018-10-29 Mon]
+| Headline     | Time   |
+|--------------+--------|
+| *Total time* | *8:00* |
+|--------------+--------|
+| Foo          | 8:00   |
+"
+         (org-test-with-temp-text
+             "* Foo
+CLOCK: [2018-10-29 Mon 08:00]--[2018-10-29 Mon 16:00] =>  8:00"
+           (let ((system-time-locale "en_US"))
+             (test-org-clock-clocktable-contents
+                 (concat ":step day "
+                         ":stepskip0 t "
+                         ":tstart \"2018-10-01\" "
+                         ":tend \"2018-11-01\"")))))))
 
 (ert-deftest test-org-clock/clocktable/extend-today-until ()
   "Test assignment of clock time to days in presence of 
\"org-extend-today-until\"."
-- 
2.17.1

signature.asc
Description: PGP signature