[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: attachment: link type export to HTML invalid attach dir
From: |
Nicolas Goaziou |
Subject: |
Re: attachment: link type export to HTML invalid attach dir |
Date: |
Wed, 26 Feb 2020 16:22:41 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Gustav Wikström <address@hidden> writes:
> Expanding attachment-links in the buffer makes the link type no longer
> be attachment.
What makes you think that? The link type is preserved during the
substitution, according to the (concat "attachment" ...).
> I would prefer if we explicitly set the link type to
> files here instead. Storing intermediate state in an attachment link
> types makes less sense imo.
>
> One issue with the current way it's done is that images are treated
> differently between attachment links and file links. For HTML exports,
> file links are wrapped in a div with class figure where expanded
> attachment links are not.
It would be nice to investigate why this happens.
> Letting org-attach-expand-links do the full
> transform to file links would solve that issue. That also
> means :export is not needed for org-link-set-parameters.
>
> Patch attached if you agree to this.
Of course! This is what I suggested, like, 6 weeks ago (although, at
this time, I was thinking about having the substitution in "ox.el").
Regards,
--
Nicolas Goaziou
- Re: attachment: link type export to HTML invalid attach dir, (continued)
- Re: attachment: link type export to HTML invalid attach dir, Bastien, 2020/02/16
- Re: attachment: link type export to HTML invalid attach dir, Nicolas Goaziou, 2020/02/17
- Re: attachment: link type export to HTML invalid attach dir, Bastien, 2020/02/17
- Re: attachment: link type export to HTML invalid attach dir, Nicolas Goaziou, 2020/02/20
- Re: attachment: link type export to HTML invalid attach dir, Bastien, 2020/02/20
- Re: attachment: link type export to HTML invalid attach dir, Nicolas Goaziou, 2020/02/22
- Re: attachment: link type export to HTML invalid attach dir, Bastien, 2020/02/22
- RE: attachment: link type export to HTML invalid attach dir, Gustav Wikström, 2020/02/25
- Re: attachment: link type export to HTML invalid attach dir,
Nicolas Goaziou <=
- RE: attachment: link type export to HTML invalid attach dir, Gustav Wikström, 2020/02/27
- Re: attachment: link type export to HTML invalid attach dir, Nicolas Goaziou, 2020/02/27
- RE: attachment: link type export to HTML invalid attach dir, Gustav Wikström, 2020/02/13
- Re: attachment: link type export to HTML invalid attach dir, Bastien, 2020/02/14