[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add semimonth step for clocktables
From: |
Kyle Meyer |
Subject: |
Re: [PATCH] Add semimonth step for clocktables |
Date: |
Thu, 26 Mar 2020 03:36:21 +0000 |
Thanks for the patch. The change looks fine to me.
A few things:
* Please update the commit message to follow the instructions at
<https://orgmode.org/worg/org-contribute.html>.
* Please send git-format-patch output either via git-send-email or as
an attachment. (At least with my usual git-am incantations, the
best I was able to do with this email's patch was to make a commit
with the proper change but with an empty commit message, including
the subject.)
* In my opinion it'd be better to send this patch as a follow-up to
the thread for the initial patch at
<https://lists.gnu.org/archive/html/emacs-orgmode/2020-03/msg00115.html>.
That way, the conversation stays in one place, and those that gave
feedback initially are more likely to see the follow-up and provide
additional feedback.
Could you send an updated patch to the original thread?
Thanks.