[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo
From: |
Kyle Meyer |
Subject: |
Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo |
Date: |
Thu, 16 Apr 2020 02:41:45 +0000 |
Adam Porter <address@hidden> writes:
> Kaushal Modi <address@hidden> writes:
>
>> Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEWS
>>
>> Compiling ox-hugo.el now gives:
>>
>> ox-hugo.el:4284:1: Warning: the function ‘org-get-outline-path’ is not known
>> to be defined.
>>
>> I see that defun has now moved to org-refile.el. I see that
>> org-get-outline-path has nothing to do specific to refiling. Can that
>> be moved back to org.el, or may be a separate library? Otherwise,
>> ox-hugo.el will have to load org-refile.el too (yes, I don't use
>> org-refile (yet), and that's how I discovered this :))
>
> Yes, please move that function back. This is going to cause breakage in
> a variety of packages that use that function but do not load
> org-refile. I can hear the bug reports rumbling already... ;)
Despite being sympathetic to any attempt to break up org.el, I agree
that it'd be good to move the outline path functionality back. Also,
there are a number of loading issues related to the org-refile move,
which can be seen by running `make single'.
I've prepared a commit that resolves these issues, which includes moving
org-get-outline-path and friends back to org.el, on the km/refile-fixups
branch:
https://code.orgmode.org/bzg/org-mode/commit/18e58aa0d7fd367b3506891b633a493f402e9fee
(It's not very useful to post it as a patch here because most of it's
code movement that's better viewed with git-diff's --color-moved.)
- Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo,
Kyle Meyer <=